Skip to content

fix(web-app): map ws:// relay URL to http:// for CSP connect-src #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Priyanshubhartistm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web-app): map ws:// relay URL to http:// for CSP connect-src #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix-csp-ws-http-scheme-mapping.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"nostream": patch
---

Fix the Content-Security-Policy `connect-src` directive for relays served over plain `ws://`.

The web app factory derived an HTTP(S) origin from the relay's WebSocket URL but mapped
`ws:` to the invalid scheme `':'`, which the WHATWG URL API silently ignores. As a result the
`connect-src` directive kept a `ws://…` entry instead of the intended `http://…` origin for
local/dev, Tor, or reverse-proxied setups. The `ws:` protocol now correctly maps to `http:`.
2 changes: 1 addition & 1 deletion src/factories/web-app-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const createWebApp = (): Express => {

const relayUrl = new URL(settings.info.relay_url)
const webRelayUrl = new URL(relayUrl.toString())
webRelayUrl.protocol = relayUrl.protocol === 'wss:' ? 'https:' : ':'
webRelayUrl.protocol = relayUrl.protocol === 'wss:' ? 'https:' : 'http:'

const directives = {
'img-src': ["'self'", 'data:', 'https://cdn.zebedee.io/an/nostr/'],
Expand Down
Loading