Repository navigation
Conversation
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With numeric
spanGaps, adding a segment-style callback reconnects line sections that exceed the configured gap limit. For example, points at x=0,5,30,35 withspanGaps: 10produce sections 0-1 and 2-3 without styling, but sections 0-1 and 1-3 with asegment.borderColorcallback. The 25-unit gap is drawn despite the existingstopflag.Change
Only reuse the previous style section's start when
spanGaps === true. Numeric gap limits already produce separate solid sections, so start each styled section at its own boundary.This preserves boolean gap-spanning behavior and does not change public APIs. It is independent of #12365, which addresses curve control points rather than style splitting.
Tests
pnpm buildincluding declaration generation andtsc --noEmit: pass._boundSegment.Firefox and downstream integration suites were not run.