Repository navigation
Conversation
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_steppedInterpolationcurrently uses the opposite before/after convention from_steppedLineTo. At an interior x value,LineElement.interpolate()can return a point on the other plateau rather than on the visible line.For a lower line from
{x: 0, y: 20}to{x: 10, y: 80}withstepped: 'before', the drawn plateau is at 20 until the last point. Interpolating at x=3 currently returns 80. Afill: 'stack'dataset with points at x=2 and x=4 therefore fills down to 80 rather than the visible plateau at 20. The opposite error occurs with'after';truehas the same issue as'before'.Swap the helper's before/after choices to match the existing drawing path. Keep both endpoints and
'middle'unchanged. No drawing or stack-target construction changes are included.This addresses the plateau sampling part of #10989, not the broader problem of preserving every interior step corner in a constructed stack target. It is independent of #12363's axis/fallback handling and #12326's multiple-segment result handling.
Tests
isPointInStroke, including endpoints, both point directions, before/after/middle and the true alias. Six fail on unchanged master.Fresh frozen-lockfile dependency install, full native ChromeHeadless suite: 1727 passed. Rollup build, declaration emit, TypeScript noEmit and ESLint on all four changed files passed. Firefox and downstream plugin tests were not run. Local Chrome launcher settings are not part of the diff.