Repository navigation
Conversation
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For a line chart with
indexAxis: 'y',fill: 'start'andfill: 'end'use the value scale'sbottomandtopcoordinates as horizontal positions. Those are Y coordinates, so the fill can end inside the chart, on the wrong side of the line, or outside the chart depending on the canvas dimensions and padding.Change
Use
scale.left/scale.rightfor horizontal value scales and retainscale.bottom/scale.topfor vertical ones. This keeps start/end as geometric scale boundaries, including reversed scales. Origin and explicit-value targets are unchanged. Radial boundaries and above/below color clipping are not changed.Tests
Added 32 native canvas cases: start/end boundaries on both index axes, reversed scales, all three filler draw timings, repeated updates, plus origin and explicit-value controls. Asymmetric layout padding ensures a Y coordinate cannot accidentally look like the correct X edge. Pixel assertions check both the filled and empty sides.
Against unmodified master, 12 horizontal boundary cases fail and 20 controls pass. With the fix, a fresh frozen-lockfile install passes all 1735 Karma/Chromium cases, the production build, declaration generation,
tsc --noEmit, and scoped ESLint with no warnings or errors. Firefox and downstream integration tests were not run locally.This is separate from #12058's above/below colors and #12363's stacked target interpolation: it only changes the coordinate selected for start/end boundary targets.