Repository navigation
perf(smtp-server): shrink_to_fit() data buffers at the end of DATA command - #267
Merged
Merged
Conversation
…mmand shrink_to_fit() is generally a bad idea because it likely reallocates memory and copies the whole buffer once, but if we keep max_size allocated (30 MB currently, but we want to change to 50 MB in chatmail/relay#1052) for each message, then a single worker with full queue will use 1.5 GB of memory. Pre-allocating to max_size and then shrinking once is likely still better than growing the buffer from zero each time.
j-g00da
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shrink_to_fit() is generally a bad idea because it likely reallocates memory and copies the whole buffer once, but if we keep max_size allocated (30 MB currently, but we want to change to 50 MB in chatmail/relay#1052) for each message, then a single worker with full queue will use 1.5 GB of memory. Pre-allocating to max_size and then shrinking once is likely still better than growing the buffer from zero each time.
Follow-up to #264, commented there: https://github.com/chatmail/filtermail/pull/264/changes#r4347363381