Repository navigation
Conversation
The security fixes that block a release are tracked in the private cilium/security repository under label:release-blocker/X.Y, and are the only pre-check item the tool does not verify itself. This commit adds a step that searches for open items carrying that label and asks for confirmation before continuing when it finds any. Most release managers cannot read cilium/security, so the step asks about the repository first and, on the 404 GitHub answers for a repository it hides, warns that the check did not run instead of failing the release; a search alone cannot tell an invisible repository from a misspelled one, as both answer 422. Like the release blockers in cilium/cilium the check is skipped for pre-releases and release candidates, and it runs before the quay.io check, which exits the process on a transport error. Signed-off-by: André Martins <andre@cilium.io>
Pre-releases are development snapshots of the next minor version, and neither the release candidate nor the minor template asks for the security release blockers to be checked before cutting one. This commit removes the item from the pre-release template, so that the checklist matches the release tool, which skips that check for pre-releases and release candidates. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/check-security-release-blockers
branch
from
October 15, 2026 09:33
270541f to
ecdc70e
Compare
joestringer
reviewed
Oct 16, 2026
joestringer
left a comment
joestringer
left a comment
Member
There was a problem hiding this comment.
LGTM, with some super minor nits for readability around the classic "double negative" case. I got confused for a bit trying to reason about this until I unwound per the suggestions below.
It would be good to test this with an upcoming release when we have a blocker to make sure that the implementation properly picks up the blockers when they're present (no typos or incorrect API handling).
Comment on lines
+146
to
+149
| // repoNotVisible reports whether err means the token cannot see the repository: | ||
| // GitHub answers 404 for a private repository it hides and 403 when an | ||
| // organization denies the token. | ||
| func repoNotVisible(err error) bool { |
Member
There was a problem hiding this comment.
nit: repoVisible() and flip the logic?
Member
There was a problem hiding this comment.
Same for searchRepoNotVisible() -> searchRepoVisible() below.
Comment on lines
+55
to
+59
| if !repoNotVisible(err) { | ||
| return fmt.Errorf("unable to fetch repository %s/%s: %w", owner, repo, err) | ||
| } | ||
| c.warnNotChecked(fmt.Sprintf("No access to the private %s/%s repository", owner, repo), releaseBlockerLabel) | ||
| return nil |
Member
There was a problem hiding this comment.
nit: Flipping this around along with the corresponding suggestion earlier makes this flow much more clearly IMO.
Suggested change
| if !repoNotVisible(err) { | |
| return fmt.Errorf("unable to fetch repository %s/%s: %w", owner, repo, err) | |
| } | |
| c.warnNotChecked(fmt.Sprintf("No access to the private %s/%s repository", owner, repo), releaseBlockerLabel) | |
| return nil | |
| if !repoVisible(err) { | |
| c.warnNotChecked(fmt.Sprintf("No access to the private %s/%s repository", owner, repo), releaseBlockerLabel) | |
| return nil | |
| } | |
| return fmt.Errorf("unable to fetch repository %s/%s: %w", owner, repo, err) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security fixes that block a release are tracked in the private
cilium/security repository under label:release-blocker/X.Y, and are the
only pre-check item the tool does not verify itself.
This adds a step that searches for open items carrying that label and
asks for confirmation before continuing when it finds any. Most release
managers cannot read cilium/security, so the step asks about the
repository first and, on the 404 GitHub answers for a repository it
hides, warns that the check did not run instead of failing the release;
a search alone cannot tell an invisible repository from a misspelled
one, as both answer 422.
Like the release blockers in cilium/cilium the check is skipped for
pre-releases and release candidates, and it runs before the quay.io
check, which exits the process on a transport error. The pre-release
template drops the item as well, so that the checklist matches the
release tool.