Scheduled reducer: use timestamp from reducer params for next run#5574
Open
Shubham8287 wants to merge 2 commits into
Open
Scheduled reducer: use timestamp from reducer params for next run#5574Shubham8287 wants to merge 2 commits into
timestamp from reducer params for next run#5574Shubham8287 wants to merge 2 commits into
Conversation
|
Please deploy this in 2.7.0 Especially if it is a regression. |
Contributor
@Shubham8287 maybe a use case for DST? |
Collaborator
The 2.7.0 release is already cut and tested, so this will likely not make it in. We may decide to do a patch release, but otherwise this will make it in to next week's release instead. |
Comment on lines
-608
to
+619
| let reschedule = delete_scheduled_function_row(module_info, db, id, None, None, inst_common, inst); | ||
| let reschedule = delete_scheduled_function_row(module_info, db, id, None, reschedule_from, inst_common, inst); |
Contributor
There was a problem hiding this comment.
In the absence of a test, could we change the type signature to always take an explicit timestamp instead of an option?
| db: &RelationalDB, | ||
| id: Option<ScheduledFunctionId>, | ||
| mut tx: MutTxId, | ||
| reschedule_from: Option<(Timestamp, Instant)>, |
Contributor
There was a problem hiding this comment.
Same question/suggestion here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
We are scheduling using
Timestamp::now()instead of last runtimestamp. It causes any interval reducer which has non-negligible execution time to gradually drift.I fixed it once back :| - #3657.
API and ABI breaking changes
NA
Expected complexity level and risk
1
Testing
I want to add a test for it, but I don't know how to add non-flaky test for it.