Repository navigation
Update rdkafka to 0.39 and fix CI - #313
Merged
Merged
Conversation
duglin
force-pushed
the
copilot/replace-pr-265-ci-fixes
branch
2 times, most recently
from
November 7, 2026 00:02
53fc8c2 to
7b6d415
Compare
Carry forward the rdkafka update and lint fix from #265, align the example dependency, and raise the rdkafka-sys constraint to the version required by rdkafka 0.39. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: duglin <1944671+duglin@users.noreply.github.com>
Install native build prerequisites in the independent lint job. Make only curl headers visible to musl-gcc, avoiding glibc include paths and keeping curl support disabled. Remove the unnecessary SASL dependency and document the build requirements. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: duglin <1944671+duglin@users.noreply.github.com>
duglin
force-pushed
the
copilot/replace-pr-265-ci-fixes
branch
from
November 7, 2026 01:01
03b532f to
8595503
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #265 with the rdkafka 0.39 upgrade, based on current main (which already includes the original lint fix).
The rdkafka example dependency is aligned to 0.39 and the rdkafka-sys constraint is raised to the compatible 4.10 release. Both the test and lint workflows install CMake and curl development headers. Musl CI exposes only curl headers to musl-gcc, without importing glibc headers or enabling curl support. The native build requirement is documented in the Kafka binding.
After rebasing, local all-feature tests, Clippy with warnings denied, formatting, the Kafka example build, and workflow linting pass. GitHub CI is running on the rebased commit.
fixes #265