Repository navigation
Conversation
prepareProject returned the details detected before framework setup, so cf dev and cf build used pre-setup commands, environment, and mode support on their first run. Setup can change a project's tooling (for example autoconfig setting up Next.js with vinext), so analyse the configured project again, as the Wrangler-migration route already does.
Contributor
|
LGTM |
commit: |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 257.8 ms | 4.0 ms | 251.7 ms | 268.9 ms |
| base | 258.5 ms | 6.3 ms | 251.9 ms | 275.6 ms |
Δ (PR vs base): — -0.6 ms (-0.2%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
MattieTK
marked this pull request as ready for review
October 11, 2026 10:39
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepareProjectreturned the project details detected before framework setup, so the firstcf devorcf buildafter setup used the pre-setup dev command, environment, and--modesupport. This change analyses the configured project again after setup, as the Wrangler-migration route already does.analyzeProject, falling back to the pre-setup details if detection fails.cf buildstill prefers the setup's build command, so framework build overrides are unchanged.With
@cloudflare/autoconfig0.7.7 this has no visible effect, because detection finds the same commands before and after setup. It is needed for cloudflare/workers-sdk#16200, which sets up Next.js 16 projects with vinext for thecftarget: without it, the firstcf devafter setup would runnext devrather thanvite dev. Later runs already pick up vinext throughlib/vinext.ts.Validation: the updated
autoconfig-migration.test.tspasses, andpnpm checkpasses. The full CLI suite has seven local failures that also fail onmainin my environment (agent environment variables, a shellCLOUDFLARE_ACCOUNT_ID, and a WSL spawn error).Merge order
This is one of three related changes:
@cloudflare/autoconfig, but it must be incfbefore step 4, otherwise the firstcf devafter setup runsnext devrather thanvite dev. (this PR)--nametovinext init) merges and is released.cftarget) is updated to pass the Worker name chosen during setup tovinext init --nameand to require the vinext release from step 2. It then merges and@cloudflare/autoconfigis released.cfbumps@cloudflare/autoconfigto the release from step 3, after fix: analyse the project again after framework setup #260 has merged.