Repository navigation
refactor: remove x-forge-globals - #25
Open
dimitropoulos wants to merge 2 commits into
Open
dimitropoulos wants to merge 2 commits into
dimitropoulos wants to merge 2 commits into
Conversation
Forge no longer reads x-forge-globals or carries the globals operation metadata it populated. Command globalCliArgs is always empty.
There was a problem hiding this comment.
🟢 Approval recommended
The extension was removed consistently across types, parsing, schemas, tests, and documentation.
0 open findings
What changed in this PR
Removes the deprecated x-forge-globals extension across Forge ingestion and Fern projection.
Changes:
- Removes extension parsing and schema support.
- Ensures
globalCliArgsis always empty. - Updates tests and documentation.
| File | Description |
|---|---|
packages/forge/overlay-types.ts |
Removes the extension type. |
packages/forge/overlay-source.ts |
Stops emitting globals from overlays. |
packages/forge/init-from-openapi.ts |
Stops reading globals from OpenAPI. |
packages/fern-forge/schemas/operation.ts |
Rejects the removed extension. |
packages/fern-forge/parser.ts |
Removes normalized globals metadata. |
packages/fern-forge/index.test.ts |
Updates accepted-field coverage. |
packages/fern-forge/README.md |
Removes extension documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
x-forge-globals was its only source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
x-forge-globalsOpenAPI extension and everything it fed.fern-forgeno longer acceptsx-forge-globalsor emits theglobalsoperation metadata.forgeno longer reads it from overlays or source specs.Schema.command.globalCliArgsis gone.x-forge-globalswas its only source.cf's matching change is cloudflare/cf#250, which re-vendors
@cloudflare/forgefrom this branch.pnpm typecheck,pnpm test, oxlint, and oxfmt pass.