Skip to content

Renovate: Update module sigs.k8s.io/structured-merge-diff/v6 to v7 - #358

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/sigs.k8s.io-structured-merge-diff-v6-7.x
Open

Renovate: Update module sigs.k8s.io/structured-merge-diff/v6 to v7#358
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/sigs.k8s.io-structured-merge-diff-v6-7.x

Conversation

@renovate

@renovate renovate Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sigs.k8s.io/structured-merge-diff/v6 v6.4.2v7.0.0 age adoption passing confidence

Release Notes

kubernetes-sigs/structured-merge-diff (sigs.k8s.io/structured-merge-diff/v6)

v7.0.0

Compare Source

  • Updates to Go 1.27
  • Switches from json-iterator serialization to stdlib json/v2 serialization

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 8am on Friday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copilot AI lite review requested due to automatic review settings September 11, 2026 03:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The v7 parser types are incompatible with Kubernetes managedfields APIs still typed against v6, so the project no longer compiles.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates sigs.k8s.io/structured-merge-diff from v6.4.2 to v7.0.0 and switches the generated parser import.

Changes:

  • Adds the v7 module and checksums.
  • Retains v6 transitively.
  • Updates generated apply-configuration parsing.

Critical finding: the v7 parser is incompatible with Kubernetes APIs still typed against v6, causing compilation failure.

File summaries
File Reviewed changes
go.sum Adds v7 dependency checksums.
go.mod Adds v7 while retaining v6 indirectly.
applyconfigurations/internal/internal.go Switches to the v7 typed parser, causing the identified incompatibility.
Review details

Files not reviewed (1)

  • applyconfigurations/internal/internal.go: Generated file
  • Files reviewed: 1/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

sync "sync"

typed "sigs.k8s.io/structured-merge-diff/v6/typed"
typed "sigs.k8s.io/structured-merge-diff/v7/typed"
@renovate
renovate Bot force-pushed the renovate/sigs.k8s.io-structured-merge-diff-v6-7.x branch from 5272e2e to ea54208 Compare September 11, 2026 08:21
Copilot AI review requested due to automatic review settings September 11, 2026 08:21
@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/internal 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/internal/internal.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated parser change causes type incompatibilities with the current managedfields API and will fail to compile.

Review details

Files not reviewed (1)

  • applyconfigurations/internal/internal.go: Generated file

Suppressed comments (1)

applyconfigurations/internal/internal.go:9

  • This generated package now exposes *structured-merge-diff/v7/typed.Parser, but the k8s.io/apimachinery v0.37.0 managedfields API is built against the v6 typed package (the retained v6 indirect requirement is evidence of that dependency). As a result, calls such as managedfields.NewSchemeTypeConverter(scheme, internal.Parser()) and managedfields.ExtractInto(..., internal.Parser().Type(...), ...) will fail to compile because the v7 types are not assignable to the v6 types. Keep the generated code on v6, or upgrade the Kubernetes dependency set to a release whose managedfields API uses v7 before switching this import.
  • Files reviewed: 1/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants