test: make TomSelect helper more robust against focus races - #2730
Merged
Conversation
Clicking `.ts-control` does not always focus the input before keys are sent, which caused the dropdown search to fail intermittently under CI load. Click the input explicitly after opening the dropdown so `send_keys` is sent to a focused field.
mroderick
marked this pull request as ready for review
July 27, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens
select_from_tom_selectagainst the flaky failure seen in CI:The helper now clicks the input explicitly after opening the dropdown, so the search keys are sent to a focused field. This should remove the race where the dropdown was opened but the input had not received focus before typing.
Verification:
spec/features/admin/meeting_spec.rb:65(the failing example) passes with the CI seed54204and five additional seeds.select_from_tom_selectpass locally.