Fix appName option and count billing events via dailyEvents - #575
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mongo connection options for driver 3.x compatibility and refines limiter billing-period event counting by combining raw event scans for the “boundary day” with dailyEvents per-day counters for subsequent days.
Changes:
- Switch Mongo connection option from
appNametoappnamefor MongoDB driver 3.x compatibility. - Update limiter
DbHelper.getEventsCountByProjectto count the partial boundary day via rawevents/repetitionscollections and sum later days viadailyEvents. - Expand limiter DB helper tests to cover dailyEvents-based counting and boundary-day filtering.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| workers/limiter/tests/index.test.ts | Aligns mocked event timestamps with the boundary-day counting model. |
| workers/limiter/tests/dbHelper.test.ts | Adds dailyEvents mocking and new tests for boundary-day vs dailyEvents counting behavior. |
| workers/limiter/src/dbHelper.ts | Implements hybrid counting logic: raw scan for boundary day + aggregated dailyEvents for later days. |
| lib/db/controller.ts | Uses lowercase appname Mongo option key for driver 3.x support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
reviewed
Jul 8, 2026
Kuchizu
force-pushed
the
perf/mongo-optimizations
branch
from
July 8, 2026 08:32
68f49f6 to
a7dcbb6
Compare
neSpecc
reviewed
Jul 8, 2026
neSpecc
approved these changes
Jul 13, 2026
Kuchizu
added a commit
that referenced
this pull request
Jul 22, 2026
* feat(grouper): add slow handle diagnostics (#549) * feat(grouper): add slow handle diagnostics * refactor(grouper): extract slow handle diagnostics into session * fix(grouper): use monotonic time and exclusive timings in slow handle diagnostics * fix(db): retry initial Mongo connection to avoid worker crash-loop (#559) * fix(db): retry initial Mongo connection to avoid worker crash-loop * fix(db): clamp Mongo reconnect env vars and test retry loop * refactor(db): move positiveIntEnv to utils * fix(task-manager): use event._id instead of groupHash in issue event URL (#569) * Initial plan * fix: use event._id instead of groupHash in task-manager event URL --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * fix(limiter): handle workspace without tariffPlanId (#571) * fix(limiter): handle workspace without tariffPlanId * fix(limiter): avoid toString on missing tariffPlanId in error message * Await provider.send in sender worker (#577) * Await provider.send in sender worker * test(sender): add test for provider.send rejection handling in worker * Fix appName option and count billing events via dailyEvents (#575) * Fix appName option ignored by mongodb driver 3.x * Count billing events via dailyEvents daily counters * Fix limiter worker tests for boundary-day counting * Add opt-in dailyEvents limiter counter * Compare old and new limiter counters via Telegram log * Trim event title to a maximum length in grouper (#574) * Trim event title to a maximum length in grouper * refactor(grouper): move title trimming into DataFilter * Trim grouper event titles * Add Sanitizer for event payload fields and drop per-event handle log * Keep sanitizer placeholder for context/addons wrapped in object * Update string context test to expect placeholder object * Document string-context sanitize handling * Cut off extra object keys instead of replacing object with placeholder --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Dobrunia Kostrigin <48620984+Dobrunia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver 3.x only accepts lowercase appname
Limiter now sums dailyEvents daily counters for full days and counts raw events/repetitions only for the partial day around lastChargeDate