Repository navigation
fix: handle rejected action analytics - #1537
Open
SelormEssey wants to merge 1 commit into
Open
SelormEssey wants to merge 1 commit into
SelormEssey wants to merge 1 commit into
Conversation
🟡 Heimdall Review Status
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1531.
@CreateActioninvokessendAnalyticsEvent()without awaiting it or attaching a rejection handler. If the analytics request fails, the detached Promise can produce an unhandled rejection and terminate the Node process during action invocation.This change attaches a rejection handler at the action decorator call site while keeping analytics fire-and-forget. The wrapped action continues to execute immediately and its return behavior is unchanged.
This PR is intentionally scoped to the action invocation path. #1408 separately addresses the analogous wallet provider initialization path.
Tests
Added a focused regression test for the
@CreateActioninvocation path. The test mocks a rejected analytics request and verifies that:unhandledRejectionescapesValidation completed successfully:
A chatbot example was not run because this change is limited to error handling around the shared analytics call and does not change action inputs, outputs, wallet behavior, or chatbot behavior.
Checklist