Repository navigation
feat: Add lipgloss-styled human output for requirement analysis commands (#219) - #241
Conversation
✅ CRAP Load Analysis: PASS (no baseline)No baseline file found at How to Enable Regression DetectionGenerate and commit a baseline file to track CRAP score changes over time: # 1. Install gaze
go install github.com/unbound-force/gaze/cmd/gaze@latest
# 2. Run tests and generate baseline
go test -coverprofile=coverage.out ./...
mkdir -p .gaze
gaze crap --format=json --coverprofile=coverage.out ./... > .gaze/baseline.json
# 3. Commit the baseline
git add .gaze/baseline.json
git commit -m "chore: add CRAP baseline for regression detection"For more information: Summary
|
|
@sedonnel the lint issue seems to be legit. Could you take a look, please? |
trevor-vaughan
left a comment
There was a problem hiding this comment.
Lint fix needed, but looks good otherwise.
|
@sedonnel this is almost there. Could you fix the lint issues so can merge it, please? |
89d0088 to
94843b8
Compare
|
@trevor-vaughan and @marcusburghardt, the linting issues have been fixed, and all checks are passing. Apologies for the delay. |
Great. Thanks @sedonnel |
marcusburghardt
left a comment
There was a problem hiding this comment.
Apologies for not catching this in the earlier review round — this one is on us.
One remaining item: the new styling.go is missing the required SPDX license header. Every other Go file in the package has it. Trivial fix.
Everything else looks good. The lint-fix commits are clean and narrowly scoped.
This review was generated by /review-pr (AI-assisted).
…nds (#219) - cmd/complypack/cli/styling.go - Added share styling definitions and rendering helpers. - cmd/complypack/cli/applicability.go - cmd/complypack/cli/delta.go - cmd/complypack/cli/requirements.go - cmd/complypack/cli/triage.go - Added implementation for human output function. - cmd/complypack/cli/coverage.go - Refactored to remove styling varables (moved to styling.go). - Refactored existing use of lipgloss to use styling.go. - cmd/complypack/cli/applicability_test.go - Refactored write human test to no longer delegate to text. - Added NoGroups test to align with text testing. - cmd/complypack/cli/delta_test.go - Refactored write human test to no longer delegate to text. - Added NoComparissons test to align with text testing. - cmd/complypack/cli/requirements_test.go - Refactored write human test to no longer delegate to text. - Added Empty test to align with previous tests. - cmd/complypack/cli/triage_test.go - Refactored write human test to no longer delegate to text - Added NoPlans test to align with previous tests
- Fixed blocking linting issues
- Fixed further linting issues
0945e20 to
a6994e3
Compare
Requested changes were addressed. Thanks
feat: Add lipgloss-styled human output for requirement analysis commands (#219)
Changes
cmd/complypack/cli/styling.go
cmd/complypack/cli/applicability.go, cmd/complypack/cli/delta.go, cmd/complypack/cli/requirements.go, cmd/complypack/cli/triage.go
cmd/complypack/cli/coverage.go
cmd/complypack/cli/applicability_test.go
cmd/complypack/cli/delta_test.go
cmd/complypack/cli/requirements_test.go
cmd/complypack/cli/triage_test.go
Summary
Added generic
styling.gofor reusable generic helper functions for lipgloss styling. Refactoredapplicability.go,delta.go,requirements.go,triage.goandcoverage.goto use lipgloss styled output for human readable reports. Also refactored applicable tests to test the human output.Related Issues