Skip to content

Update module github.com/sigstore/sigstore-go to v1.2.1 [SECURITY] (main) - #3399

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/main-go-github.com-sigstore-sigstore-go-vulnerability
Open

Update module github.com/sigstore/sigstore-go to v1.2.1 [SECURITY] (main)#3399
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/main-go-github.com-sigstore-sigstore-go-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/sigstore/sigstore-go v1.1.4v1.2.1 age adoption passing confidence

sigstore-go has a multi-log threshold bypass via single compromised log

CVE-2026-49834 / GHSA-9vcr-p3rj-q5q6

More information

Details

Impact

What kind of vulnerability is it? Who is impacted?

A verifier configured with WithTransparencyLog(N>1) or WithSignedCertificateTimestamps(N>1) expected defense-in-depth against the compromise of a single log instance. However, threshold counting counted verified witnesses per-entry or per-validation-path rather than per-log-authority.

As a result, a single compromised transparency log could forge multiple entries with different indices, and a single compromised CT log could verify multiple times (either across multiple certificate chains or via multiple embedded SCTs), fully satisfying the multi-log threshold requirements and defeating the multi-log policy.

Note that this does not affect Cosign, as Cosign sets a threshold of 1.

Patches

Has the problem been patched? What versions should users upgrade to?

Upgrade to v1.1.5.

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?

There is no workaround, beyond relying on trusted logs.

Severity

  • CVSS Score: 5.9 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:H/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


sigstore-go fails to check signature timestamps against a signing key's validity period

CVE-2026-54787 / GHSA-wqqc-jjcq-vfxm

More information

Details

sigstore-go fails to check signature timestamps against a signing key's validity period for self-managed long-lived keys without certificates.

Impact

To verify a bundle with a self-managed long-lived key, the key needs to be wrapped in an ExpiringKey type that implies expiration semantics:

signatureVerifier, _ := signature.LoadDefaultVerifier(publicKey)
expiredKey := root.NewExpiringKey(signatureVerifier, time.Unix(0, 0), time.Unix(1, 0))

Despite the API contract, the validator does not check the bundle signing time against the validity window. Attackers that obtain expired key materials may be able to sign bundles with those materials that are accepted despite a configured expiry date. This issue only impacts the long-lived signing key workflow, and not standard deployments involving a certificate authority.

Reproduction steps

Start from a sigstore-go checkout:

git clone https://github.com/sigstore/sigstore-go.git
cd sigstore-go
git checkout 8ca80c47ef03d26ebf174db7c296700b075b2c16

Apply the patch containing the test case and associated materials:

git apply sigstore-go-public-key-validity-test.patch

Run the test:

go test ./pkg/verify -run TestPublicKeyValidityCheckedAgainstSignedTimestamp

On vulnerable code, the test fails because verification succeeds even though the trusted ExpiringKey is not valid at the signed timestamp:

--- FAIL: TestPublicKeyValidityCheckedAgainstSignedTimestamp
    signed_entity_test.go:602:
        	Error:      	An error is expected but got nil.

Severity

  • CVSS Score: 3.1 / 10 (Low)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:L/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

sigstore/sigstore-go (github.com/sigstore/sigstore-go)

v1.2.1

Compare Source

What's Changed

v1.2.1 resolves GHSA-wqqc-jjcq-vfxm.

  • Check signature time against public key validity window in #​642

Full Changelog: sigstore/sigstore-go@v1.2.0...v1.2.1

v1.2.0

Compare Source

What's Changed

New Contributors

Full Changelog: sigstore/sigstore-go@v1.1.4...v1.2.0


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate

renovate Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: acceptance/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 6 additional dependencies were updated

Details:

Package Change
github.com/in-toto/in-toto-golang v0.10.0 -> v0.11.0
github.com/in-toto/attestation v1.1.2 -> v1.2.0
github.com/sigstore/rekor-tiles/v2 v2.0.1 -> v2.2.2-0.20260601073857-5d098a2b6443
github.com/sigstore/timestamp-authority/v2 v2.0.4 -> v2.1.2
github.com/theupdateframework/go-tuf/v2 v2.4.1 -> v2.4.2-0.20260407074541-7e8f69f906ef
github.com/transparency-dev/formats v0.0.0-20251017110053-404c0d5b696c -> v0.1.1

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 10, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:43 PM UTC · Completed 8:48 PM UTC
Commit: 87c4a29 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review

Findings

Low

  • [dependency removal] acceptance/go.mod:57 — The upgrade removes transitive dependencies for cloud KMS providers (cloud.google.com/go/kms, aws/aws-sdk-go-v2/service/kms, Azure/azure-sdk-for-go/sdk/azcore). If any acceptance tests exercise cloud KMS-based signing or verification through sigstore-go, those tests would fail at runtime with import resolution errors. This is likely benign if the acceptance suite only uses local/file-based keys, but worth confirming CI passes.
Previous run

Looks good to me

Previous run (2)

Looks good to me

Previous run (3)

Looks good to me


Labels: PR bumps Go module dependencies in acceptance/go.mod

Previous run (4)

Review

Verdict: Comment — medium-severity observation, non-blocking.

This is a Renovate-generated dependency bump updating github.com/sigstore/sigstore-go from v1.1.4 to v1.2.0 in the acceptance/ sub-module to address CVE-2026-49834 (CVSS 5.9/Medium — multi-log threshold bypass via single compromised transparency log). The changes are confined to acceptance/go.mod and acceptance/go.sum, with transitive dependency updates pulled in by the new version.

The PR correctly updates the acceptance module. No source code, tests, or configuration files are modified. No secrets, injection patterns, or permission changes detected.

Findings

⚠ Medium — Incomplete security fix across modules

File: go.mod (line 333), tools/go.mod (line 483)

The root go.mod and tools/go.mod still pin github.com/sigstore/sigstore-go at v1.1.4 (as an indirect dependency), which remains affected by CVE-2026-49834. This PR only bumps the version in acceptance/go.mod.

While the vulnerability specifically requires multi-log threshold configurations (N>1) and may not be exploitable in all usage patterns, the production binary is built from the root module. No other open PR currently addresses the root module update.

Remediation: Update sigstore-go to v1.2.0 in the root go.mod and tools/go.mod as well, or confirm that a separate update is planned / these modules are unaffected by the CVE's specific preconditions.


Review dimensions
Dimension Result
Correctness ✅ No logic changes — dependency-only update
Security ⚠ Root module still references vulnerable version
Intent & coherence ✅ Mechanical Renovate update, authorization implicit
Style & conventions ✅ No style concerns — generated change
Documentation ✅ No documentation staleness — no code changes
Cross-repo contracts ✅ No exported API changes
Previous run (5)

Review — approve

Security dependency update — sigstore-go v1.1.4 → v1.2.0 (CVE-2026-49834)

This Renovate bot PR updates sigstore-go and its transitive dependencies in the acceptance/ module to address CVE-2026-49834 (CVSS 5.9 Medium), a multi-log threshold bypass vulnerability.

What was reviewed

  • Files changed: acceptance/go.mod, acceptance/go.sum (2 files, 220+/228−)
  • Primary update: github.com/sigstore/sigstore-go v1.1.4 → v1.2.0
  • Related direct dependency updates: sigstore/rekor v1.5.0 → v1.5.2, sigstore/sigstore v1.10.5 → v1.10.8, in-toto/in-toto-golang v0.10.0 → v0.11.0, secure-systems-lab/go-securesystemslib v0.10.0 → v0.11.0, go-openapi/strfmt v0.26.1 → v0.26.3
  • Notable transitive changes: tink-crypto/tink-go-awskms/v2/v3 (major version bump), addition of filippo.io/mldsa (post-quantum signatures), removal of unused DB driver dependencies (jackc/pgx, go-sql-driver/mysql), various go-openapi package updates

Assessment

Correctness: The go.mod and go.sum changes are internally consistent. No application code is modified. Dependency resolution follows standard Go module semantics.

Security: The PR correctly patches CVE-2026-49834 in the acceptance test module. The vulnerability requires configuring WithTransparencyLog(N>1) or WithSignedCertificateTimestamps(N>1) — a pattern not used anywhere in this codebase. The main module's go.mod still carries sigstore-go v1.1.4 // indirect, but practical risk is minimal since (a) the CVE requires multi-log threshold > 1 which is not configured, and (b) the indirect dependency is pulled in through cosign/v3 which uses threshold 1.

Scope: Changes are entirely within the acceptance/ module (test infrastructure). No production code is affected.

Compatibility risk: Low. While the transitive dependency changes are extensive, they are managed by Go's module system and the acceptance test suite will validate compatibility.

Finding

Severity Category File Description
low security/dependency-lag go.mod The root module still depends on sigstore-go v1.1.4 (indirect, via cosign/v3). While CVE-2026-49834 does not practically affect this codebase (multi-log threshold > 1 is not configured), consider updating the root module's sigstore-go dependency for consistency and defense-in-depth. This may require a separate PR if cosign/v3 hasn't updated its dependency chain.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jul 10, 2026
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.40% <ø> (-0.01%) ⬇️
generative 16.36% <ø> (ø)
integration 27.58% <ø> (ø)
unit 71.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renovate
renovate Bot force-pushed the renovate/main-go-github.com-sigstore-sigstore-go-vulnerability branch from 501eda7 to 076ea61 Compare July 14, 2026 19:56
@github-actions github-actions Bot added size: L and removed size: XL labels Jul 14, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:57 PM UTC · Completed 8:02 PM UTC
Commit: 87c4a29 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment and removed ready-for-merge All reviewers approved — ready to merge labels Jul 14, 2026
@renovate
renovate Bot force-pushed the renovate/main-go-github.com-sigstore-sigstore-go-vulnerability branch from 076ea61 to 196bf21 Compare July 21, 2026 01:08
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:09 AM UTC · Completed 1:16 AM UTC
Commit: 87c4a29 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge dependencies Pull requests that update a dependency file go Pull requests that update Go code and removed requires-manual-review Review requires human judgment labels Jul 21, 2026
@renovate
renovate Bot force-pushed the renovate/main-go-github.com-sigstore-sigstore-go-vulnerability branch from 196bf21 to 52a61c0 Compare July 22, 2026 13:45
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:46 PM UTC · Completed 1:58 PM UTC
Commit: 87c4a29 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@renovate
renovate Bot force-pushed the renovate/main-go-github.com-sigstore-sigstore-go-vulnerability branch from 52a61c0 to 7889d39 Compare July 30, 2026 22:09
@github-actions github-actions Bot added size: M and removed size: L labels Jul 30, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 30, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:10 PM UTC · Completed 10:17 PM UTC
Commit: 87c4a29 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@renovate renovate Bot changed the title Update module github.com/sigstore/sigstore-go to v1.2.0 [SECURITY] (main) Update module github.com/sigstore/sigstore-go to v1.2.1 [SECURITY] (main) Aug 1, 2026
@renovate
renovate Bot force-pushed the renovate/main-go-github.com-sigstore-sigstore-go-vulnerability branch from 7889d39 to 9c93796 Compare August 1, 2026 02:47
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 1, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:48 AM UTC · Completed 2:57 AM UTC
Commit: 87c4a29 · View workflow run →

Comment thread acceptance/go.mod
@@ -55,11 +55,7 @@ require knative.dev/eventing v0.49.2 // indirect

require (
cel.dev/expr v0.25.1 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] dependency removal

The upgrade removes transitive dependencies for cloud KMS providers (cloud.google.com/go/kms, aws/aws-sdk-go-v2/service/kms, Azure/azure-sdk-for-go/sdk/azcore). If any acceptance tests exercise cloud KMS-based signing or verification through sigstore-go, those tests would fail at runtime with import resolution errors. This is likely benign if the acceptance suite only uses local/file-based keys, but worth confirming CI passes.

Suggested fix: Confirm acceptance test CI passes. If cloud KMS tests exist and fail, the removed dependencies may need to be re-added as direct dependencies or the tests updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code main ready-for-merge All reviewers approved — ready to merge renovate size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants