fix: move audit-log-viewer from examples/ to apps/, wire prod deploy [] - #11274
Merged
Mitch Goudy (mgoudy91) merged 2 commits intoAug 13, 2026
Merged
Conversation
Andrew's PR landed the app under examples/, which lerna's package glob (apps/**/*) doesn't cover, so build/test/lint/deploy never picked it up. Moves it to apps/audit-log-viewer, drops the now-inaccurate "-example" suffix from the package name, and adds the deploy script pointing at the real prod app definition id (7xmKcOcvWM7l2vVhjUpmwB) so the existing lerna/CircleCI pipeline can publish it.
Mitch Goudy (mgoudy91)
changed the title
…iewer events.test.ts reads test-fixtures/contentful-audit-TESTORG-*.json, but that file was never committed: the repo-wide .gitignore rule contentful-audit-*.json (meant to keep real customer audit-log exports out of git) also matched this synthetic fixture. It only worked locally because the file happened to exist on disk; since the app lived under examples/, CI never ran its tests to catch the gap. Adds a narrow negation for the fixture path and recreates the file. Also commits package-lock.json, matching every other app under apps/ (examples/**/package-lock.json is gitignored, but apps/ apps commit their lockfile for reproducible CI installs).
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
Mitch Goudy (mgoudy91)
deleted the
mgoudy/move-audit-log-viewer-to-apps
branch
August 13, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audit-log-viewerfromexamples/toapps/— lerna's package glob isapps/**/*(seelerna.json), so the app was invisible to build/test/lint/deploy in feat: add audit-log-viewer example app [] #11271.audit-log-viewer-exampletoaudit-log-viewersince it's no longer an example.deployscript wired to the real prod app definition id (7xmKcOcvWM7l2vVhjUpmwB), matching the pattern used bybulk-exporterandlocale-field-populator, so the existing lerna/CircleCI pipeline can publish it.Test plan
apps/audit-log-viewer(previously skipped)npm run deploy(lerna) publishes the bundle to app definition7xmKcOcvWM7l2vVhjUpmwBon merge to master