Skip to content

Additional work on tools/call and resources/read - #118

Merged
dawid-nowak merged 12 commits into
mainfrom
dawid.nowak/additional_work_for_tools_and_resources
Aug 28, 2026
Merged

Additional work on tools/call and resources/read#118
dawid-nowak merged 12 commits into
mainfrom
dawid.nowak/additional_work_for_tools_and_resources

Conversation

@dawid-nowak

@dawid-nowak dawid-nowak commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
  1. Extra unit tests to cover modern to modern, legacy to modern, modern to legacy and legacy to legacy flows.
  2. Additional configuration parameters needs to be sent from the control plane:
  • protocol version
  1. Enabled filtering by tool name and resource uri alias.

…filter by tool name, resource uri

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…filter by tool name, resource uri.Fixing unit tests

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…filter by tool name, resource uri.Adding extra tests

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…filter by tool name, resource uri.Adding extra tests.2

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>

@lucarlig lucarlig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for three blocking correctness and test-coverage issues.

Comment thread crates/contextforge-data-plane-apis/src/user_store.rs Outdated
Comment thread crates/contextforge-data-plane-lib/tests/gateway_call_tools.rs Outdated
…d tools and resources due to overlap with aliases

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
@dawid-nowak
dawid-nowak requested a review from lucarlig August 27, 2026 12:16
Comment thread crates/contextforge-data-plane-lib/src/gateway/identifier_routing.rs Outdated
…ting refactoring

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…ting refactoring.2

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
…ting refactoring.3

Signed-off-by: Dawid Nowak <nowakd@gmail.com>
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
@dawid-nowak
dawid-nowak requested a review from lucarlig August 28, 2026 08:19
Signed-off-by: Dawid Nowak <nowakd@gmail.com>

@cafalchio cafalchio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucarlig lucarlig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested e2e all seem good.
LGTM

@dawid-nowak
dawid-nowak merged commit ca337f5 into main Aug 28, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants