fix(runtime): validate implicit 200 responses - #2362
Open
pmcelhaney wants to merge 1 commit into
Open
pmcelhaney wants to merge 1 commit into
pmcelhaney wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statusagainst the OpenAPI200response definitiondefaultresponse behaviorOriginal Prompt
Fix the confirmed bug where response validation is bypassed when a handler relies on the implicit HTTP 200 status. Create a dedicated branch and PR with a changeset.
Manual acceptance tests
statusand a required200response header returns its body with aresponse-type-errorheader.status: 200.defaultresponse still applies when the effective status has no explicit response entry.Tasks
Verification
mise exec node@24 -- yarn buildmise exec node@24 -- yarn workspace @counterfact/runtime test— 28 suites, 367 tests passedmise exec node@24 -- yarn typecheckmise exec node@24 -- yarn lint— passed with existing warnings onlymise exec node@24 -- yarn test— 64 suites, 945 tests, 127 snapshots passedmise exec node@24 -- yarn test:packed-consumermise exec node@24 -- yarn release:preflightgit diff --checkRepository learning check