alarmtimer: Fix argument order in alarm_timer_forward() - #23
Open
CeRRiLLo89 wants to merge 1 commit into
Open
Conversation
firebird11
force-pushed
the
16.0-raphael
branch
from
August 31, 2026 14:37
163140c to
8a36a95
Compare
commit 5d16467ae56343b9205caedf85e3a131e0914ad8 upstream. alarm_timer_forward() passes arguments to alarm_forward() in the wrong order: alarm_forward(alarm, timr->it_interval, now); However, alarm_forward() is defined as: u64 alarm_forward(struct alarm *alarm, ktime_t now, ktime_t interval); and uses the second argument as the current time: delta = ktime_sub(now, alarm->node.expires); Passing the interval as "now" results in incorrect delta computation, which can lead to missed expirations or incorrect overrun accounting. This issue has been present since the introduction of alarm_timer_forward(). Fix this by swapping the arguments. Fixes: e7561f1 ("alarmtimer: Implement forward callback") Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260323061130.29991-1-zhanxusheng@xiaomi.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ulrich Hecht <uli@kernel.org> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
CeRRiLLo89
force-pushed
the
backport-alarmtimer-16.0-raphael
branch
from
September 6, 2026 16:11
86144fe to
0d79961
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the upstream/stable alarmtimer fix already present in the generic
16.0branch to the Raphael-specific16.0-raphaelbranch.16.0-raphaelstill calls:while
alarm_forward()expects(alarm, now, interval).This applies the existing crDroid commit
e62c836e42a0db585fa3b337e9bbb04dde74c282with no functional adaptation.Current review state
8a36a953995212a06d0c353fe986f0f2b408762a0d79961eb6ae0247d2fea0dc7947726a1ed98422kernel/time/alarmtimer.cThe branch was rebuilt cleanly after the upstream
16.0-raphaelhistory changed. The patch hunk is unchanged from the previous PR head.Validation
16.0fixNo runtime symptom is attributed to this change; this PR is a narrow source backport only.
Previous head
86144fe4a1da0ec062268ffa77f4f55d358c08fcis preserved in the fork asbackup-pr23-pre-rebuild-20260906.