Skip to content

msm: ipa: fix PM suspend callbacks - #24

Open
CeRRiLLo89 wants to merge 2 commits into
crdroidandroid:16.0-raphaelfrom
CeRRiLLo89:backport-ipa-pm-16.0-raphael
Open

msm: ipa: fix PM suspend callbacks#24
CeRRiLLo89 wants to merge 2 commits into
crdroidandroid:16.0-raphaelfrom
CeRRiLLo89:backport-ipa-pm-16.0-raphael

Conversation

@CeRRiLLo89

@CeRRiLLo89 CeRRiLLo89 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Backport the existing IPA/RMNET PM fixes from the generic 16.0 branch to 16.0-raphael.

The first commit moves the IPA and RMNET suspend callbacks out of suspend_noirq, because the GSI interrupt handler cannot run in the noirq phase and force_coals can get stuck waiting for that interrupt.

The second commit fixes the PM callback pairing, using suspend_late / resume_early so a failed suspend is paired with the correct resume phase.

Backported fixes:

  • c0f532d46388c9ed6b6aedb98ea781d778e4ae45 — msm: ipa: Fix the force_coals command stuck issue on AP suspend
  • 7c72845156e2c077fcaf4cfc8fed4d8fb6c7629a — msm: ipa3: Fix to use paired PM operation for IPA

Current review state

  • Base: 8a36a953995212a06d0c353fe986f0f2b408762a
  • Head: 49789cb98c7d41d277ebdfaef2ee6bf6353bef28
  • 2 commits
  • 2 changed files
  • final callbacks: suspend_late / resume_early
  • no device-specific logic added

The branch was rebuilt cleanly after the upstream 16.0-raphael history changed.

Stable patch-ids are unchanged:

  • first commit: 84075dbae8c793a37bb0ab1e955655b13204edfc
  • second commit: e719efd5257a0c540b417bb36d1c7b451ad1cea2

Validation

  • both backports applied cleanly onto the current base
  • git diff --check passed
  • exactly 2 commits
  • exactly 2 changed files
  • final callbacks match the generic 16.0 implementation
  • no unrelated changes

Previous head 180bd16c633e1b4b6961a6e605c25ec3a293326a is preserved as backup-pr24-pre-rebuild-20260906.

Bojun Pan and others added 2 commits September 6, 2026 18:20
IPA force_coals command stuck due to not getting the gsi interrupt.
The suspend on IPA AP/RMNET_IPA driver was registered as noirq type,
gsi interrupt handler won't be called because of this.
The fix is to change the suspend cb from suspend_noirq to suspend.

Change-Id: I148c981b0edb28c414a30b991294b2683b198399
Signed-off-by: Bojun Pan <bojunp@codeaurora.org>
Signed-off-by: Andrzej Perczak <linux@andrzejperczak.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Becauase of using wrong pair of PM operation device
was not resuming if suspend fails. Adding changes to
use correct set of PM operations.

Change-Id: Ib9fdea8f93f0a6dafbd5908dc8fc2bbf4f1e0904
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
Signed-off-by: Andrzej Perczak <linux@andrzejperczak.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
@CeRRiLLo89
CeRRiLLo89 force-pushed the backport-ipa-pm-16.0-raphael branch from 180bd16 to 49789cb Compare September 6, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant