Repository navigation
test: build expected advisor and organization dates in UTC - #444
Merged
Merged
Conversation
The fixtures carry an explicit +00:00 offset, which DateDeserializer honors since #443. The date helpers still used the JVM default time zone, matching the old offset-ignoring behavior, so 7 tests failed outside UTC. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
andrii-bodnar
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#443 changed
DateDeserializerto respect the time zone offset in a timestamp. Before that, it parsed2026-04-16T12:00:00+00:00as 12:00 in the JVM's default time zone and ignored the+00:00.AdvisorsApiTestandOrganizationApiTestwere written against that old behavior. TheirlocalDate()helpers still build expected dates in the JVM's default time zone, so 7 tests fail on any machine that isn't set to UTC. CI stays green only because GitHub's runners use UTC.The fixtures for these tests all use an explicit
+00:00offset, so the expected dates should be interpreted as UTC.Fix
Four lines: in each test class, the helper uses
ZoneId.of("UTC")instead ofZoneId.systemDefault(), and its comment, which still described the old behavior, is corrected. Helper names, imports, fixtures and production code are unchanged.Testing
Each class run on its own, so that tests which change the JVM's default time zone can't hide a failure:
AdvisorsApiTestbeforeAdvisorsApiTestafterOrganizationApiTestbeforeOrganizationApiTestafterThe full suite passes with all 899 tests in both UTC and America/Los_Angeles.
🤖 Generated with Claude Code