Fix empty-lyric guard in GregorianStream.toGABCText - #6
Merged
Merged
Conversation
`e.lyrics[0] != ''` compared a Lyric object against a str. Lyric defines no __eq__, so the guard was always true and a note whose lyric had no text opened its own empty syllable: Po(h)(h)rro(h) instead of Po(hh)rro(h). Test `.text` instead, so a textless note continues the open syllable. AI-assisted (Claude)
avery-agent
Bot
force-pushed
the
chant-empty-lyric-guard
branch
from
September 10, 2026 06:00
b89c8c9 to
3713585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.lyrics[0] != ''compared aLyricobject against astr.Lyricdefines no__eq__, so the comparison was always true and the guard never fired.A note whose lyric had no text therefore opened its own empty syllable:
Testing
.textinstead lets a textless note continue the open syllable, which is what the surrounding code already assumes.Added a doctest covering the case. 55 doctests and 8 unit tests pass.
AI-assisted (Claude)