Drop the polyfill for the engine's findConfigDirs - #19
Draft
grouville wants to merge 1 commit into
Draft
Conversation
The engine now ships Workspace.findConfigDirs (dagger/dagger#13769): the same cwd-aware project discovery this module got from github.com/dagger/polyfill — same semantics, ported from the polyfill's own design and test matrix. Swap the call, drop the dependency, and require the engine release that ships it. The engineVersion bump and the dependency removal have to land together: the version gate is what keeps the engine's new changeset behavior scoped to migrated modules. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vitest module currently uses
dagger/polyfillto find projects below the directory where Dagger was run, or the nearest project above it when invoked from a subdirectory.That exact behavior is now available as
Workspace.findConfigDirsin dagger/dagger#13854. This PR switches the discovery call and removes the wrapper. Vitest arguments, execution, and result handling do not change.Test
dagger checkAll 6 checks pass, including ancestor and descendant discovery and fixtures with expected test failures. The provisional engine version will be updated after #13854 is released.