ja: use the Japanese geometry terms - #724
Merged
Merged
Conversation
Verbose said 半直線 A から B まで, which claims the ray stops at B. A ray has A as its endpoint and continues through B, so read it as A を始点として B を通る. A segment does end at its second point, so から...まで stays there; a test now pins the two apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth of the small PRs from #715, independent of #720, #721, #722 and #723.
What is wrong
The seeded geometry rules and the geometry entries of
definitions.yamltransliterate the English words rather than use the Japanese terms. For this area the terms are completely settled -- they are what a textbook introduces in the first year of junior high.Two of these are more than word choice:
line-segmentanddirected-line-segmentwere both ラインセグメント, so the distinction between them disappeared.The Verbose branches were English word order carried over with the wrong particles (「ラインセグメントから A に B」); they now read 「線分 A から B まで」.
A ray does not stop at its second point
ensays "the ray from A to B", where "to" means "in the direction of". Rendering that with 「まで」 claims the ray ends at B. A ray has A as its endpoint and continues through B without end, so Verbose reads 「半直線 A を始点として B を通る」. A segment does end at its second point, so から...まで is right there. The second commit fixes this and adds a test that pins the two apart; CodeRabbit caught it on my preflight branch.Deliberately not touched
enI asked about in ja: read fractions in Japanese word order #720 and Create a Japanese (ja) translation #715.Tests
geometry_terms(the five intent forms),geometry_point, andgeometry_verbose_from_to(segment against ray under Verbose).Spotted, left for later
In the same block of
definitions.yaml,change(Δ) is 変更点, "a point that was changed"; the quantity is 変化量.