pl: restore sum and product arity templates after the connector fix - #783
Merged
Merged
Conversation
Collaborator
|
Thanks. I never would have guessed that "z" => "of". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #739 and the Polish verification report.
Now that the engine reads the connector from the language definitions instead of hard-coding English "of", restore the Polish arity templates for
sumandproduct:FunctionApplicationWord: ["z"].function=suma | przez | od,doandfunction=iloczyn | przez | od,do.For example,
sum($i,$x)becomes "suma przez i z x" instead of "suma z i przecinek, x", andsum($i,$n,$x)becomes "suma od i do n z x". The corresponding product forms use "iloczyn". The one-argument forms remain unchanged.The Polish wording follows the existing large-operator rules. This changes only
Rules/Languages/pl/definitions.yamlandtests/Languages/pl/definitions.rs. No engine or braille changes; independent of #764.Verification
Rechecked against current
mainat374ea588cd77edc1745b8a632da1d23ec6e9c71f(crate 0.7.6-rc.4):cargo test --test languages Languages::pl -j2: 625 passed, 0 failed.--features no-unsafe: 625 passed, 0 failed.sequence_and_series_intentsfailed on the intended difference: expected "suma przez i z x", actual "suma z i przecinek, x". Restoring the definitions makes it pass again.git diff --checkpasses. The diff contains only the two files listed above.