feat: Dash Platform client library behind --enable-platform-gui - #7626
Draft
PastaPastaPasta wants to merge 6 commits into
Draft
feat: Dash Platform client library behind --enable-platform-gui#7626PastaPastaPasta wants to merge 6 commits into
PastaPastaPasta wants to merge 6 commits into
Conversation
native_rust installs the pinned prebuilt Rust toolchain as a native package and rust_stdlib provides the precompiled standard library for every supported cross target; contrib/devtools/update-rust-hashes.py maintains both pins together. funcs.mk gains a cargo environment wired to the depends cross toolchain and a per-package crate-vendoring template: any package that declares a vendored archive name and a cargo manifest gets a vendor-<package>-crates target and extracts the archive before building, so cargo builds run locked and fully offline.
…I knob
PLATFORM_GUI=1 adds mbedtls, native_protobuf, tenderdash_sources and platform_cxx to the package set. platform_cxx builds libdash_platform_cxx.a and its installed headers from a pinned dashpay/platform commit (packages/rs-platform-cxx), offline via the per-package vendored crates. config.site.in exports enable_platform_gui and PLATFORM_CXX_{CFLAGS,LIBS} discovery for the configure flag that arrives with the first C++ consumer.
…lane The new lane builds depends with PLATFORM_GUI=1 (producing and hash-verifying the Platform CXX archive offline from vendored crates), then builds dash-qt against that prefix and runs the unit tests. The cache-sources producer generates and caches the platform-cxx vendored-crates archive, handing it to same-run consumers as an artifact on cache miss. The --enable-platform-gui configure flag is added to this lane's BITCOIN_CONFIG by the Platform client library PR; until then the lane proves the depends knob and prefix link-compatibility. build.yml runs PR validation from the base branch (pull_request_target), so the lane first runs on push CI for this branch and takes effect for PRs after merge.
libdash_platform.a is a DAPI client for the Dash Platform GUI: a gRPC-Web-over-TLS transport on mbedtls with per-query endpoint pinning and scoped freshness, GroveDB drive queries whose proofs verify through the Platform-owned CXX bridge bound to the quorum-signed root, DPP identity/document decoding and state-transition construction where the signable bytes are the broadcast bytes, and versioned serialization for DashPay's per-wallet records. The new --enable-platform-gui configure flag requires the GUI and wallet, autodetects mbedtls and link-tests the Platform CXX archive from depends. Nothing outside the flag changes: dashd and default builds do not compile or link any of this.
Unit suites for the transport (dechunking, retry, freshness), DPP and drive layers run against Rust-generated fixed vectors: GroveDB proofs (keys, ranges, subqueries, absence, references, sum trees), DPP identities and state transitions, drive queries and quorum signatures. platformkeys_tests gains Platform record round-trip and payment-cursor coverage, and a fuzz target exercises the bridge's decode and verify entry points.
…lane The lane introduced with the depends knob now passes --enable-platform-gui to configure, so the platform unit suites run in CI.
This was referenced Aug 20, 2026
|
This pull request has conflicts, please rebase. |
5 tasks
Member
Author
|
Disposition (not closing yet): superseded by #7670, which rebuilds this library as a thin consumer of the Platform SDK (dashpay/platform#4633). The C++ transport, protobuf/CBOR encoders, retry and freshness code and their unit tests retire; the DPP byte-exactness suite, the wallet-key tests and the decoder fuzz targets stay. Each security fix here has a home in the new stack (map in #7512). 🤖 Posted autonomously by Claude on behalf of pasta. |
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 8, 2026
…ble-platform-gui The Qt-free client library dash-qt drives for DashPay: per-network parameters and system contract ids, the PlatformClient interface, DPP decoding and state-transition adapters, and the wallet record formats. Where the earlier revision (dashpay#7626) carried its own gRPC-Web/TLS transport, hand-written protobuf and CBOR encoders, per-endpoint retry and freshness tracking, and handed request/response byte pairs to a transport-free verifier, this one is a thin consumer of the Dash Platform SDK through dash-platform-cxx (dashpay/platform#4633). The SDK owns query construction, DAPI transport, retries with address banning, proof verification (GroveDB replay plus the Tenderdash quorum signature against the keys this node pushes from its LLMQ store), protocol-version tracking and the chain-id and ChainLock freshness checks; the node supplies evonode endpoints from its deterministic masternode list, the Platform quorum keys, its best ChainLock height and wallet signatures through a digest callback, so private keys never leave the wallet. The PlatformClient interface the GUI programs against is unchanged apart from gaining an sdk() accessor; the production implementation keeps its single worker thread and callback marshalling and forwards each query to the SDK handle. Absence stays proven, never inferred: an empty result only reaches a callback after the SDK verified a proof of it. The DPP decoders and state-transition builders take the SDK handle so they build under the protocol version the SDK has seen the network run, ratcheted up from the per-network floor in params.cpp. The C++ transport, protobuf, CBOR, retry and freshness code and their unit tests are gone with the design; the DPP byte-exactness suite and the wallet key tests stay, and the fuzz harness keeps the decoder targets (proof verification is fuzzed upstream). Validated on aarch64-apple-darwin against a depends prefix carrying the SDK-backed archive: configure detects the bindings, libdash_platform.a and test_dash build, platform_dpp_tests and platformkeys_tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Second PR of the DashPay series (stacked on #7623; tracking: #7512). DashPay needs a client for Dash Platform: DAPI transport, cryptographic proof verification, DPP document/identity handling and state-transition construction. This PR adds that client library, compiled and linked only under the new
--enable-platform-guiconfigure flag.dashdand every non-GUI binary are byte-for-byte unaffected in default builds.What was done?
First two commits are #7623 (depends: Rust toolchain +
platform_cxxbehindPLATFORM_GUI=1) — review the commits after those.--enable-platform-gui: requires the GUI + wallet, autodetects mbedtls (with brew support on macOS), locates the Platform CXX archive viaPLATFORM_CXX_{CFLAGS,LIBS}(exported by depends'config.site), and link-tests it at configure time.src/platform/(libdash_platform.a):transport/: gRPC-Web-over-TLS DAPI client on mbedtls — HTTP/1.1 + chunked/dechunking, protobuf codecs, per-query endpoint pinning with scoped freshness, retry/rotate-out.drive/: GroveDB query construction and proof verification through the Platform-owned Rust bridge (platform_ffi), root-hash-bound to the quorum-signed metadata.dpp/: identity/document decoding and state-transition build+sign (signable bytes == broadcast bytes).walletrecords.h/cpp: versioned serialization for DashPay's per-wallet records (identity record, payment cursors) — pure functions, storage arrives with the GUI PR.platform_client_tests,platform_dpp_tests,platform_drive_testswith Rust-generated fixed vectors (GroveDB proofs, DPP identities, state transitions, drive queries, quorum signatures), Platform-record + payment-cursor coverage inplatformkeys_tests, and aplatform_bridgefuzz target over the bridge's decode/verify entry points.linux64_platform_guilane (added in build: consume Dash Platform CXX bindings from depends #7623) now configures with--enable-platform-guiand runs the platform suites.How Has This Been Tested?
--enable-platform-guibuild and the platform unit suites + fuzz smoke on this branch (macOS arm64).Breaking Changes
None. Everything is behind
--enable-platform-gui(default off).Checklist: