fix: interpolate ${secret.*} tokens inside larger strings - #147
Merged
Merged
Conversation
Substitution previously required the entire field to be a secret reference. Embedded tokens are now replaced, and resolved values stay redacted in logs via SecretValue repr.
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${secret.alias}when it is embedded in a larger string, not only when it is the entire field value.SecretValueso Spark still receives the real secret viastr(), while logs and debug prints stay redacted viarepr().VERSIONtov0.23.9.Test plan
pytest tests/unit/test_secrets_manager.py(whole-field, embedded, unknown alias, dict logging redaction)${secret.*}tokens in a composite option string resolves at runtime[REDACTED], not secret plaintext