Conversation
…ynthetic bundle To upload a run's code snapshot, air run used to construct a fake in-memory bundle just to call the bundle library's artifact uploader. This uploads the tarball directly with libs/filer instead, and renames the file and function since the path no longer goes through DABs. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: fc8a32d
Top 3 slowest tests (at least 2 minutes):
|
caroline-db
approved these changes
Sep 18, 2026
caroline-db
left a comment
caroline-db
left a comment
Contributor
There was a problem hiding this comment.
implementation lgtm. can you update a couple of stale comments referring to dabs upload before merging?
- runsubmit.go - left a review comment here
- runsubmit_test.go - quite a few stale comments here
Comment on lines
339
to
341
| // Package and upload the code snapshot, if any, via DABs' artifact-upload | ||
| // plumbing; the remote code_source_path rides the ai_runtime_task. A run with no | ||
| // code_source leaves it empty. Snapshot is the only code_source type. |
Contributor
There was a problem hiding this comment.
nit - can you update this comment to reflect the new implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
To upload a run's code snapshot,
air runused to construct a fake in-memory bundle just so it could call the bundle library's artifact uploader. This uploads the tarball directly withlibs/filerinstead. A newsnapshotUploadFilerpicks the destination (a Volume filer for/Volumespaths, a workspace filer otherwise, both under<artifact_path>/.internal), and the upload is a plainfiler.Write. The file and its function are renamed (snapshot_dabs.gotosnapshot_upload.go,snapshotViaDABsUploadtouploadSnapshot) since the path no longer goes through DABs.Why
Removes air's dependency on the bundle package internals for what is really just a file upload. Behavior is unchanged: both packaging modes, the content-addressed skip,
remote_volumerouting, and theUploading ...line are preserved. Drops the directbundle*,libs/vfs,libs/dyn, andservice/jobsimports.Tests
Build, vet, and the air acceptance suite pass; unit tests pass except the pre-existing
TestSubmitWorkloadfailure in unrelated code.This pull request and its description were written by Isaac.