Skip to content

Restore cursor shape behaviour for Emacs mode#1610

Merged
j-bennet merged 4 commits into
dbcli:mainfrom
pinn3:restore-emacs-cursor-shape
Jul 24, 2026
Merged

Restore cursor shape behaviour for Emacs mode#1610
j-bennet merged 4 commits into
dbcli:mainfrom
pinn3:restore-emacs-cursor-shape

Conversation

@pinn3

@pinn3 pinn3 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

I have my cursor configured to be a block character in my terminal emulator because it's more visible to me

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install).
  • I verified that my changes work as expected (this may include manually testing them in your local environment, or in other available environments). Cross this out if not relevant (for example, if you're making a documentation change).
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@dbaty

dbaty commented Jul 20, 2026

Copy link
Copy Markdown
Member

I can confirm the fix:

before:

Capture d’écran du 2026-07-20 11-59-46

after:

Capture d’écran du 2026-07-20 12-01-13

I'll review that this week (I don't know this part of the code). Thanks for your contribution.

@j-bennet

Copy link
Copy Markdown
Contributor

This looks good to me, according to the docs here, ModalCursorShapeConfig is meant for vi mode.

@j-bennet

Copy link
Copy Markdown
Contributor

Thanks @pinn3 , merging.

@j-bennet
j-bennet merged commit fab13f0 into dbcli:main Jul 24, 2026
8 of 17 checks passed
@pinn3
pinn3 deleted the restore-emacs-cursor-shape branch July 24, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants