DigestInfo validation to prevent RSA-PKCS#1 v1.5 signature forgery - #1151
Closed
Zelzazor wants to merge 2 commits into
Closed
DigestInfo validation to prevent RSA-PKCS#1 v1.5 signature forgery#1151Zelzazor wants to merge 2 commits into
Zelzazor wants to merge 2 commits into
Conversation
4 tasks
4 tasks
Author
|
Closed in favor of #1152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1149.
Basically, validation of
DigestInfostructure inverify()function for RSA PKCS#1 v1.5 inrsa.jswas not validating any nested properties located between the required parts of said structure, allowing a forged signature to pass.I've made an additional check inside the
ifof theDigestInfostructure validation, in order to check what is the length of the capturedDigestAlgorithm, and compare it to it's only possible values.A regression test was made inside
tests/unit/rsa.jsto detect the forged signature. Test was executed before making the change with an expected fail state. Then executed the full test suite: 816 passing, 0 failing.Created a CHANGELOG entry documenting the fix and a CVE reference.
CVE: CVE-2026-85393