Perf #36439 -- Added performance benchmark for acheck_password hashing via asyncio#94
Open
roelzkie15 wants to merge 1 commit into
Open
Perf #36439 -- Added performance benchmark for acheck_password hashing via asyncio#94roelzkie15 wants to merge 1 commit into
acheck_password hashing via asyncio#94roelzkie15 wants to merge 1 commit into
Conversation
6 tasks
27c72d2 to
47829a5
Compare
…tion using different password hasher. This is related to django/django/pull/19611
47829a5 to
61e8967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This performance benchmark was added as part of the django/django/pull/19611 as requested by the reviewer.
Setup
Using the following
asv.config.jsonfile:{ "version": 1, "project": "Django", "project_url": "https://www.djangoproject.com/", "repo": "https://github.com/roelzkie15/django.git", "branches": ["main"], "build_command": [ "python -m pip install build bcrypt argon2-cffi", "python -m build --wheel -o {build_cache_dir} {build_dir}" ], "environment_type": "conda", "show_commit_url": "https://github.com/roelzkie15/django/commit/", "pythons": ["3.12", "3.13"] }You may also use
virtualenvfor theenvironment_type, just make sure you're in a virtual environment.Collecting data
Getting the result of the
mainbranch (HEAD).Getting the result of the pull request's branch
fix-36439-auth-hashing-performance.Then compare the benchmark:
Result output from my benchmark: