Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

Simple template not working out of the box on web #75

Description

@jldinh

When running a newly instantiated simple template and opening it in a browser, it fails to load and an error in the console complains about exports not being defined in react-sharedb/lib/index.js.

I tracked it down to the webpack config not compiling node_modules dependencies by default, resulting in this error, because AFAIK exports only exists in Node and not in browsers.
Adding @startupjs/react-sharedb to forceCompileModules in webpack.web.config.js solves the problem, but I wonder if it wouldn't make more sense for react-sharedb's lib folder to be directly useable in a browser.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions