[aw] Refresh nightly fix finder categories - #12689
Conversation
Replace exhausted no-op categories with dead-code and stale-reference scans, and allow complete localized diagnostic fixes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9f6e114-ab17-428b-aa77-c86b55a9b5e2
There was a problem hiding this comment.
🟡 Changes recommended
The new dead-code scan has avoidable worst-case runtime costs and the string-literal scan can fail the workflow when there’s nothing to scan, which risks noisy or slow nightly runs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Refreshes the nightly-fix-finder agentic-workflow categories to avoid repeated no-op runs and to unblock otherwise-valid localization fixes by narrowing/retargeting scans and expanding what the workflow is allowed to change.
Changes:
- Replaces the “unused using” and “AsyncTask Log property misuse” categories with new scans for provably dead code and stale Xamarin-era prose/links.
- Tightens the string-literal diagnostic category to resource-backed projects and expands guidance to allow cohesive resource + XA-doc updates.
- Extends safe outputs to allow
README.mdedits and regenerates the compiled workflow lock.
File summaries
| File | Description |
|---|---|
| .github/workflows/nightly-fix-finder/08-string-literal-error-messages.sh | Restricts scan to resource-backed projects and refines filtering/guidance for localization-safe diagnostics. |
| .github/workflows/nightly-fix-finder/07-stale-xamarin-references.sh | Adds a new category to find stale Xamarin/Mono-era prose and outdated documentation links. |
| .github/workflows/nightly-fix-finder/07-asynctask-log-property.sh | Removes the AsyncTask Log-misuse category script. |
| .github/workflows/nightly-fix-finder/06-unused-using-directives.sh | Removes the unused-using category script. |
| .github/workflows/nightly-fix-finder/06-completely-dead-code.sh | Adds a new “completely dead code” category with unreachable-construct and private-identifier heuristics. |
| .github/workflows/nightly-fix-finder.md | Updates workflow docs/category list and clarifies the cohesive scope for resource-backed diagnostic fixes; allows README changes. |
| .github/workflows/nightly-fix-finder.lock.yml | Regenerates compiled workflow lock to reflect category and safe-output changes. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
Precompute singleton identifiers in one pass and treat an empty resource inventory as a successful no-op. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9f6e114-ab17-428b-aa77-c86b55a9b5e2
|
/review |
|
✅ Android PR Reviewer completed successfully!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Needs Changes
Findings: 0 errors, 1 warning, 0 suggestions.
The new categories are conservative, the diagnostic-localization workflow now permits cohesive resource changes, and the generated workflow reflects the source configuration. One reliability issue remains in the stale-reference scanner: its known provenance exclusion is tied to a mutable line number.
CI is still in progress; all completed checks currently pass.
Generated by Android PR Reviewer for #12689 · gpt56 · 134.5 AIC · ⌖ 20.1 AIC · ⊞ 25.7K
Comment /review to run again
Match the known aprofutil provenance URL rather than its movable source line. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9f6e114-ab17-428b-aa77-c86b55a9b5e2
Why
The no-op history in #11506 shows that the unused-using and AsyncTask logging categories have stopped producing actionable changes, while the string-literal diagnostic category rejects otherwise valid fixes that require new resources.
Changes
06-unused-using-directiveswith a conservative dead-code detector for unreachable constructs and unreferenced private members.07-asynctask-log-propertywith focused scans for stale Xamarin-era prose and documentation links.README.mdfixes produced by the stale-reference category.08-string-literal-error-messagesto resource-backed projects, filter localized and pass-through diagnostics, and permit complete resource/XA documentation changes.Validation
pipefailenabled.nightly-fix-finderwithgh aw compile nightly-fix-finder --strict.Closes #11506