Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The round-robin assignor raises
KeyErrorwhen it skips a consumer that does not subscribe to the current topic: the skip loop receives an(instance ID, member ID)tuple but uses it as a member ID. Its grouping step can also omit earlier static/dynamic runs when the join response interleaves membership types.Sort the complete member list in the established static-first order, then cycle only member IDs. This preserves every member independently of input order and makes subscription skipping consistent with initial selection.
Fixes #3201. Tests cover differing subscriptions and all input permutations for dynamic/static/mixed membership, idle members, missing metadata, coordinator subscription decoding, and a JoinGroup/SyncGroup exchange through the existing MockBroker transport.
Validation: the final targeted selection has 22 failures and two passing controls on unchanged upstream; all 24 pass with the fix. All 560 consumer/coordinator tests pass on CPython 3.12 and 3.14; the full non-integration suite has 2,782 passes and one skip on 3.12.
make lint, source/wheel build and diff checks pass. No live Kafka broker test was run.