Skip to content

DP-499 Integrateio sso - #102

Closed
tomonorman wants to merge 6 commits into
developfrom
DP-499
Closed

tomonorman wants to merge 6 commits into
developfrom
DP-499

Conversation

@tomonorman

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/Utility/Session.php Outdated
Comment thread src/Utility/Session.php
Comment thread src/Utility/Session.php
/** @noinspection PhpUndefinedFieldInspection */
$user->last_login_date = Carbon::now()->toDateTimeString();
/** @noinspection PhpUndefinedFieldInspection */
$user->confirm_code = 'y';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this y? Is it not an issue if it's the same value for all users? I see confirm_code which is usually a security feature, so I am just wondering.
@tomonorman @krishnapriawan

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just means the user is "confirmed" (yes, no) rather than an actual "code" so to speak.

@daniilly
daniilly force-pushed the develop branch 4 times, most recently from 8d2da3e to c91d00a Compare March 3, 2023 11:09
@nicdavidson

Copy link
Copy Markdown
Contributor

Closing as part of a repository backlog cleanup — this has been inactive for over a year. If it's still relevant, please reopen or leave a comment and we'll take another look. Thanks!

@nicdavidson nicdavidson closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants