docs(windows): correct PHP version requirements - #104
Open
nicdavidson wants to merge 1 commit into
Open
Conversation
The prerequisites checklist said 'PHP 8.1 or 8.3' and the PHP section pinned 8.3.16. composer.json requires php ^8.3, which admits 8.3, 8.4 and 8.5, and our Linux installer provisions 8.5. Both statements were wrong, and 8.1 is not supported at all. State of Vermont followed this page onto 8.1 during a 7.7 install. Also: - warn against --ignore-platform-reqs rather than leaving it as an escape hatch - stop pinning oci8 3.2.1 against a hardcoded 'DreamFactory runs on PHP 8.3'; tell the reader to match their installed PHP instead
✅ Deploy Preview for dreamfactory-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows install page gave two wrong PHP answers.
Prerequisites checklist said
PHP 8.1 or 8.3.PHP section said "the latest supported PHP version is 8.3.16" and linked a direct 8.3.16 download.
composer.jsonrequires"php": "^8.3", which admits 8.3, 8.4 and 8.5.config.platform.phpis8.3. Our Linux installer setsDEFAULT_PHP_VERSION="php8.5"andcentos.shhas anassert_php85_activecheck, so 8.5 is what we actually build and test against.So the page excluded the version we ship and recommended one we do not support.
State of Vermont followed this page onto PHP 8.1 during a 7.7 install this week.
Changes
PHP 8.3 or newer, note that 8.1 and 8.2 are unsupported^8.3constraint, note 8.5 is what the Linux installer provisions, point readers at therequireblock of their shippedcomposer.jsonas authoritative--ignore-platform-reqsinstead of leaving it as an undocumented escape hatchPaired with https://github.com/dreamfactorysoftware/df-wiki/pull/11, which fixes the same text on the wiki copy of this page.