[JacksonYao287]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 67.66467% with 54 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable/v4.x@fff21f7). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/lib/homestore_backend/hs_http_manager.cpp	37.25%	30 Missing and 2 partials ⚠️
src/lib/homestore_backend/hs_debug_inject.cpp	82.95%	11 Missing and 4 partials ⚠️
src/lib/homestore_backend/hs_pg_manager.cpp	57.14%	2 Missing and 1 partial ⚠️
src/lib/homestore_backend/scrub_manager.cpp	57.14%	3 Missing ⚠️
...lib/homestore_backend/snapshot_receive_handler.cpp	0.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@              Coverage Diff               @@
##             stable/v4.x     #479   +/-   ##
==============================================
  Coverage               ?   54.75%           
==============================================
  Files                  ?       40           
  Lines                  ?     7046           
  Branches               ?      955           
==============================================
  Hits                   ?     3858           
  Misses                 ?     2773           
  Partials               ?      415           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xiaoxichen]

Can we make it seperate API:

1. local_delete_shard_meta (shard_id)
2. local_delete_blob (blob_id)
3. local_replace_blob(blob_id, blob_header, blob_data)

The last one can be enhance later into the api that used for replacing corrupted object locally. You can start with assert(new_len <= original_len) to ensure inplace update is possible

[JacksonYao287]

I would suggest to keep it like this for now since I want to use it only for scrubber integration test.

after we are clear about what functionalities we want / how to audit / how to prevent these restful apis from being abused, then we can have a seperate PR to make those change.

[JacksonYao287]

I cherry-pick add_missing_pg_scrub_superblks from #475, so that we can add scrub_super_blk to those pgs leak of scrub_super_blk

[xiaoxichen]

then can we make this pr into v5？ or into another dev branches？ if this PR is still a testing/draft

[JacksonYao287]

v5 is now being tested by storage hammer and not stable yet. I dont want to do scrubber test on a unstable branch. if you are concerned about the data injection part, its good for me to add this part into a dedicated branch for scrubber testing.

for the add_missing_pg_scrub_superblks code, it is necessary to be merged into this branch. so ,
1 change this PR to only add add_missing_pg_scrub_superblks
2 create another branch for scrubber testing and add the data corrupted api to this branch.

[xiaoxichen]

sure yes lets add the add_missing_pg_scrub_superblks part into v4 and the testing code can be merged to whereever you like