Repository navigation
feat(nx): route PRT files to the one matching running NX without discarding working copies - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User problem
Already-deployed Windows 10/11 CloudFile Agent opens PRT files using directly spawned
ugraf.exe -retrieve:<path>, causing a new NX window on each open. The direct-retrieveroute was validated on real customer NX 7.5 machines and must be preserved as the no-running-session fallback.Change
ugraf.exeusing native ToolHelp APIs. Inspect the actual executable path viaQueryFullProcessImageNameWwithout CMD, PowerShell, PATH or administrator privilege.ugraf.exe -retrieve:<file>launch, retaining NX7.x Unicode-path checks and detected version/working-directory rules.ugs_router.exeis available, pass-ug -use_file_dir <file>as separate native argv. This is the known Siemens association command for activating existing NX sessions, but its success must still be validated in real NX. User-defined open rules retain precedence.ugraf.exeor guess at a Teamcenter session.routed_nxin the existingopened.json(older records stay readable). Deleting a previously routed NX working copy requires explicit user confirmation even if the PID subsequently disappears. Existing file-lock check remains first, and no other files in the folder are removed.Test evidence
cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings, andcargo test --workspace --locked --no-fail-fastall PASS (one pre-existing ignored OS-keyring test).ticks.is_multiple_of(150)Rust lint and the stale installer-guard Node test update already in fix(agent2): periodic update checks, portable Win10/11 compatibility and clearer V2 errors #30 so the Windows CI baseline can actually run, without changing installers. Reconcile these identical baseline fixes after fix(agent2): periodic update checks, portable Win10/11 compatibility and clearer V2 errors #30 is merged.Gate before merge or publishing
Draft: not real Windows/NX verification. Must verify Win10 and Win11 ordinary-user workstations with NX7.5, NX12, NX2306+; absent/one/multiple sessions; managed Teamcenter; file route from Chrome, same-file repeat, local-view/edit, commit/upload and deletion protection. Correct result means the file actually appears in the existing NX session, not merely that
ugs_router.exeexited 0. Do not merge or deploy on CI alone.CI / Windows installer compatibility follow-up
[WARN]/[ERROR]tags before existing Chinese messages, to make Windows CI fail-closed checks and support logs stable across Windows code pages..gitattributesnow marks the-textCMD files aswhitespace=cr-at-eolsogit diff --checkcorrectly accepts mandatory CRLF while still prohibiting Git encoding/newline conversion. Added small deterministic installer tests asserting the exact safety tags. No scripts are executed on live customer machines.