bug: consume request body before sending response - #2066
Open
cstamas wants to merge 1 commit into
Open
Conversation
As otherwise MITM proxies may translate this as server error and produce 50x errors.
Contributor
|
LGTM |
autumnfound
approved these changes
Aug 12, 2026
cstamas
marked this pull request as ready for review
August 14, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As otherwise LB/proxies may translate this as server error and produce 50x errors downstream.
Changes:
Fixes EclipseFdn/open-vsx.org#12463
Note: Changed code is/will conflict with trusted publishing, where even the "verify" use case has been totally separated out. This PR merely copies the applicable bits from trusted publishing
AccessTokenServiceand adds body consumption before throwing error (and modifies error from 400 to 401).