Repository navigation
containers: link unit tests to comp_req requirements via RecordProperty - #568
Merged
Merged
Conversation
Nikhil2206
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
September 10, 2026 07:16
Nikhil2206
had a problem deploying
to
workflow-approval
September 10, 2026 07:16 — with
GitHub Actions
Failure
Nikhil2206
had a problem deploying
to
workflow-approval
September 10, 2026 07:16 — with
GitHub Actions
Failure
Nikhil2206
had a problem deploying
to
workflow-approval
September 10, 2026 07:16 — with
GitHub Actions
Failure
Nikhil2206
had a problem deploying
to
workflow-approval
September 10, 2026 07:16 — with
GitHub Actions
Failure
Contributor
|
Documentation preview for this pull request is available at: |
Nikhil2206
had a problem deploying
to
workflow-approval
September 11, 2026 08:25 — with
GitHub Actions
Failure
Nikhil2206
had a problem deploying
to
workflow-approval
September 11, 2026 08:25 — with
GitHub Actions
Failure
Nikhil2206
had a problem deploying
to
workflow-approval
September 11, 2026 08:25 — with
GitHub Actions
Failure
Nikhil2206
had a problem deploying
to
workflow-approval
September 11, 2026 08:25 — with
GitHub Actions
Failure
Nikhil2206
marked this pull request as draft
September 11, 2026 08:25
Nikhil2206
marked this pull request as ready for review
September 16, 2026 07:28
Nikhil2206
temporarily deployed
to
workflow-approval
September 16, 2026 07:28 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 16, 2026 07:28 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 16, 2026 07:28 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 16, 2026 07:28 — with
GitHub Actions
Inactive
Nikhil2206
had a problem deploying
to
workflow-approval
September 17, 2026 06:27 — with
GitHub Actions
Error
Nikhil2206
had a problem deploying
to
workflow-approval
September 17, 2026 06:27 — with
GitHub Actions
Error
Nikhil2206
had a problem deploying
to
workflow-approval
September 17, 2026 06:27 — with
GitHub Actions
Error
Nikhil2206
temporarily deployed
to
workflow-approval
September 17, 2026 06:38 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 17, 2026 06:38 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 17, 2026 06:38 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 17, 2026 06:38 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several traceability records are incomplete or unsupported, and the modified architecture need requires a version bump.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (2)
score/containers/non_relocatable_vector_special_member_funcs_test.cpp:376
- This touched test records the descriptive metadata but has no
FullyVerifiesorPartiallyVerifiesproperty, leaving an incomplete traceability record. Since the deterministic-behavior requirement cannot describe an operation that deliberately allocates, either remove the test metadata and document the deliberate exception or add an accurate requirement for this behavior.
this->RecordProperty("TestType", "resource-usage");
this->RecordProperty("DerivationTechnique", "equivalence-classes");
this->RecordProperty("Description",
"Check that copy-constructing a NonRelocatableVector allocates memory based on the "
"source's capacity, not its current size.");
score/containers/dynamic_array_test.cpp:821
- A leak check proves that allocated memory is released, not that no dynamic allocation occurred as required by
comp_req__containers__deterministic_behavior. With onlyEXPECT_TRUE(true)in the ordinary test configuration, this linkage records verification without an assertion of the requirement.
this->RecordProperty("PartiallyVerifies", "comp_req__containers__deterministic_behavior");
- Files reviewed: 8/8 changed files
- Comments generated: 5
- Review effort level: Balanced
Nikhil2206
had a problem deploying
to
workflow-approval
September 18, 2026 12:31 — with
GitHub Actions
Error
Nikhil2206
had a problem deploying
to
workflow-approval
September 18, 2026 12:31 — with
GitHub Actions
Error
Nikhil2206
had a problem deploying
to
workflow-approval
September 18, 2026 12:31 — with
GitHub Actions
Error
Nikhil2206
had a problem deploying
to
workflow-approval
September 18, 2026 12:31 — with
GitHub Actions
Error
Nikhil2206
temporarily deployed
to
workflow-approval
September 18, 2026 12:33 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 18, 2026 12:33 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 18, 2026 12:33 — with
GitHub Actions
Inactive
Nikhil2206
temporarily deployed
to
workflow-approval
September 18, 2026 12:33 — with
GitHub Actions
Inactive
4og
approved these changes
Sep 18, 2026
4og
enabled auto-merge
September 18, 2026 16:04
4og
disabled auto-merge
September 18, 2026 16:15
srinivasugithub
pushed a commit
to bgsw-contrib/score_baselibs
that referenced
this pull request
Sep 21, 2026
…st-req-trace containers: link unit tests to comp_req requirements via RecordProperty
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #522. Adds
RecordPropertytraceability metadata linkingscore/containersunit tests to theircomp_req__containers__*requirements.Files touched:
dynamic_array_test.cpp,intrusive_list_test.cpp,non_relocatable_vector_test.cpp,non_relocatable_vector_emplace_back_test.cpp,non_relocatable_vector_special_member_funcs_test.cpp.Validated:
bazel test --config=bl-x86_64-linux //score/containers/...→ 7/7 test targets PASSED.Deliberately left unlinked (with reasoning)
non_relocatable_vector_special_member_funcs_test.cpp:CannotCopyVectorContainingNonCopyableType, and the twoNonMoveableAndCopyableElementTypeFixturevariants ofMoveConstructingMovesAllElements/MoveAssigningMovesAllElements— these have empty bodies (just comments documenting that type traits can't detect true non-compilability at runtime); nothing to assert or link.test/fake_memory_resource_test.cpp,test/fancy_pointer_allocator_test.cpp— these test-infrastructure self-tests (test doubles), notcontainerslibrary behavior. Nocomp_reqclaims anything about them, so left entirely unlinked.Fixes #523