Skip to content

concurrency: replace legacy Verifies/ASIL tags with comp_req RecordProperty links - #571

Merged
4og merged 7 commits into
eclipse-score:mainfrom
Nikhil2206:nk-concurrency-test-req-trace
Sep 22, 2026
Merged

concurrency: replace legacy Verifies/ASIL tags with comp_req RecordProperty links#571
4og merged 7 commits into
eclipse-score:mainfrom
Nikhil2206:nk-concurrency-test-req-trace

Conversation

@Nikhil2206

@Nikhil2206 Nikhil2206 commented Sep 10, 2026 •
edited by 4og
Loading

Copy link
Copy Markdown
Contributor

Summary

Part of #522. Replaces the legacy ASIL/Verifies RecordProperty tags in synchronized_queue_test.cpp with the current PartiallyVerifies: comp_req__concurrency__synchronized_queue linkage convention.

Partially addresses #551

@github-project-automation github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Sep 10, 2026
@github-actions github-actions Bot added comp-concurrency Related to score/concurrency c++ C++ code labels Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-571: https://eclipse-score.github.io/baselibs/pr-571/

@Nikhil2206 Nikhil2206 closed this Sep 11, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in BAS - Baselibs FT Sep 11, 2026
@Nikhil2206 Nikhil2206 reopened this Sep 11, 2026
@Nikhil2206
Nikhil2206 marked this pull request as draft September 11, 2026 08:24
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 17, 2026 05:48 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 17, 2026 05:48 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 17, 2026 05:48 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 17, 2026 05:48 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 marked this pull request as ready for review September 17, 2026 07:26
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 08:23 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 08:23 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 08:23 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 08:23 — with GitHub Actions Active
@4og
4og requested a balanced review from Copilot September 22, 2026 09:48
Copilot AI reviewed Sep 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The updated metadata accurately links relevant tests while removing unsupported legacy claims.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@github-project-automation github-project-automation Bot moved this from Done to On Hold in BAS - Baselibs FT Sep 22, 2026
@4og
4og enabled auto-merge September 22, 2026 10:24
@4og
4og added this pull request to the merge queue Sep 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 22, 2026
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 11:14 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 11:14 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 11:14 — with GitHub Actions Active
@Nikhil2206
Nikhil2206 deployed to workflow-approval September 22, 2026 11:14 — with GitHub Actions Active
@4og
4og enabled auto-merge September 22, 2026 12:02
@4og
4og disabled auto-merge September 22, 2026 12:11
@4og
4og merged commit 987528c into eclipse-score:main Sep 22, 2026
23 of 27 checks passed
@github-project-automation github-project-automation Bot moved this from On Hold to Done in BAS - Baselibs FT Sep 22, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — 83d4d2c1 Deployed Sep 22, 2026 by Nikhil2206 via Build and Test bl-x86_64-qnx / approval #2044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@4og 4og 4og approved these changes
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@fbaeuerle fbaeuerle Awaiting requested review from fbaeuerle fbaeuerle is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@arkjedrz arkjedrz Awaiting requested review from arkjedrz arkjedrz is a code owner

Assignees

No one assigned

Labels

c++ C++ code comp-concurrency Related to score/concurrency

Projects

BAS - Baselibs FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nikhil2206 @4og