Skip to content

someip communication middleware bindings impl - #1036

Closed
sergejwinterbmw wants to merge 2 commits into
eclipse-score:mainfrom
sergejwinterbmw:agents/communication-middleware-bindings-impl
Closed

sergejwinterbmw wants to merge 2 commits into
eclipse-score:mainfrom
sergejwinterbmw:agents/communication-middleware-bindings-impl

Conversation

@sergejwinterbmw

Copy link
Copy Markdown
Contributor

No description provided.

Issue: SWP-279538
Issue: SWP-279538
@sergejwinterbmw
sergejwinterbmw force-pushed the agents/communication-middleware-bindings-impl branch from a9fd0f1 to 4fee53a Compare September 2, 2026 08:00
@sergejwinterbmw
sergejwinterbmw marked this pull request as draft September 2, 2026 11:32
} // namespace detail

template <typename SkeletonServiceElementBinding, typename SkeletonServiceElement, ServiceElementType element_type>
//TODO: can this be changed to not change all callsite for every added binding?

@pawelrutkaq pawelrutkaq Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ie:

template <typename SampleType>
SampleType SampleTypeOf(const SkeletonEventBinding<SampleType>&);

and then in someip lambda

using SampleType = decltype(detail::SampleTypeOf(std::declval<const SkeletonServiceElementBinding&>()));

At the end You need SampleType or ?

@pawelrutkaq

pawelrutkaq commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

SkeletonMethodBindingFactoryImpl along with SkeletonMethodBindingFactory are missing passing T (Ret + Args) down to the binding.
This is opposite to proxy impl and will make it hard to connect serialization for SOME/IP once it needs to know the type.

/// Holds everything that differs between two instances of the same service interface. In contrast to the LoLa binding
/// there are no shared memory sizes or slot counts here, since SOME/IP transports serialized messages over a socket
/// instead of shared memory.
class SomeIpServiceInstanceDeployment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deployment would need more params in practice that can even be SOME/IP stack-dependent.
The question is if we will provide those as Key/Value, untyped or no support at all. Some kind of support would allow no need to patch upstream shared code in which we are now

@pawelrutkaq

pawelrutkaq commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Additionally, there is less of a funny effect that happens. If ie example will create Event for std::array, the code will instantiate both SomeIP and Lola implementations and I guess the linker cannot remove them since it has no clue what exactly will be used. Just noting this, may be helpfull for code size investigations.

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants