mw/com/impl: Type erased proxy binding - #1079
Merged
Merged
Conversation
crimson11
requested review from
LittleHuba,
bemerybmw,
castler,
hoe-jo and
limdor
as code owners
September 14, 2026 14:30
crimson11
force-pushed
the
mf_type_erased_proxy_binding
branch
from
September 14, 2026 14:52
3b8ffae to
1cf6c28
Compare
SebSparrowHawk
approved these changes
Sep 22, 2026
Tejveerpratap2803
approved these changes
Sep 24, 2026
bemerybmw
requested changes
Sep 24, 2026
crimson11
force-pushed
the
mf_type_erased_proxy_binding
branch
from
September 24, 2026 21:31
1cf6c28 to
a39d6ba
Compare
| event_name_{event_name}, | ||
| // The transaction log is identified by the application's unique identifier. | ||
| transaction_log_id_{ | ||
| static_cast<TransactionLogId>(GetBindingRuntime<lola::IRuntime>(BindingType::kLoLa).GetApplicationId())}, |
bemerybmw
requested changes
Sep 25, 2026
crimson11
force-pushed
the
mf_type_erased_proxy_binding
branch
2 times, most recently
from
September 25, 2026 11:44
b933a44 to
dc6607c
Compare
This commit now makes also the proxy side binding layer type-erased (after a previous PR did the type-erasure for the skeleton side).
crimson11
force-pushed
the
mf_type_erased_proxy_binding
branch
from
September 25, 2026 12:09
dc6607c to
c8875aa
Compare
bemerybmw
enabled auto-merge
September 25, 2026 13:14
bemerybmw
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit now makes also the proxy side
binding layer type-erased (after previous
PR #897 did the type-erasure for the skeleton side).