Conversation
…lookup DecoratorType was a subclass instead of a pass-through alias, making ProvidedServices<ProvidedServiceDecorator> and ProvidedServices<DecoratorType> unrelated types, so dynamic_cast-based lookups (GetServices/Get/Has) always failed even after a service was added. Fix: make DecoratorType a pure alias and use it consistently. Fixes config_daemon crashing with "Failed to create InitialQualifierStateSender callback".
Add GetProxyFuture()/StopServiceDiscovery() and a ProxyFuture constructor to the Optional<T> stub so it matches how config_management's ConfigProviderImpl and its unit tests actually use OptionalProxyData<T> (constructed from a pending future, not an already-resolved unique_ptr).
Chahult
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
September 15, 2026 08:06
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.