Conversation
Added create/delete activity of files and verify, that corresponding notifications are received on all watchers in time.
crimson11
force-pushed
the
mf_extend_inotify_stress_test
branch
from
September 15, 2026 15:21
28546e3 to
993b866
Compare
| const std::string file_path{kBaseFolder + "/" + kNotifyTestFileName}; | ||
| if (create) | ||
| { | ||
| const int fd{::open(file_path.c_str(), O_CREAT | O_WRONLY | O_TRUNC, 0644)}; |
| { | ||
| // Unblocks the pending Read() call in the helper thread. | ||
| inotify.Close(); | ||
| static_cast<void>(read_future.wait()); |
There was a problem hiding this comment.
ClangTidy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Due to issues we saw in QNX8 regarding losses of inotify events, the existing stress test has been extended, to also cover inotify-event reception. One test-mode was added to show inotify event reception by multiple watchers on the same directory in a graceful/ non-bursting event scenario. Anotjer test-mode was added, where the inotify-events were created in a burst (mass create/delete of files in the watched dir). This second test-mode (which reveals QNX8 issues) has then been extracted in a minimal/stand-alone test-case to be easier shareable with support. The relation between the stand-alone test and the aggregated stress-test and its modes is documented.
crimson11
force-pushed
the
mf_extend_inotify_stress_test
branch
from
September 16, 2026 14:32
4d5623b to
4e53bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to issues we saw in QNX8 regarding losses of
inotify events, the existing stress test has been
extended, to also cover inotify-event reception.
One test-mode was added to show inotify event reception
by multiple watchers on the same directory in a graceful/
non-bursting event scenario.
Anotjer test-mode was added, where the inotify-events were
created in a burst (mass create/delete of files in the watched
dir).
This second test-mode (which reveals QNX8 issues) has then been
extracted in a minimal/stand-alone test-case to be easier shareable
with support. The relation between the stand-alone test and the
aggregated stress-test and its modes is documented.