Add DR about module folder structure - #3194
Open
aschemmel-tech wants to merge 2 commits into
Open
aschemmel-tech wants to merge 2 commits into
aschemmel-tech wants to merge 2 commits into
Conversation
github-project-automation
Bot
added this to
S-CORE Roadmap and TLC - Technical Lead Circle
aschemmel-tech
marked this pull request as ready for review
August 19, 2026 09:39
aschemmel-tech
requested review from
PandaeDo,
masc2023 and
pahmann
as code owners
August 19, 2026 09:39
masc2023
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
PiotrKorkus,
RolandJentschETAS and
anmittag
August 19, 2026 10:18
PandaeDo
previously approved these changes
Aug 19, 2026
masc2023
requested changes
Aug 19, 2026
masc2023
left a comment
masc2023
left a comment
Contributor
There was a problem hiding this comment.
Get feedback from Communities, Feature Teams
Contributor
Author
|
Discussed with FT's: |
MaciejKaszynski
previously approved these changes
Aug 20, 2026
MaciejKaszynski
left a comment
MaciejKaszynski
left a comment
Contributor
There was a problem hiding this comment.
Fine with lifecycle
LittleHuba
previously approved these changes
Aug 20, 2026
AlexanderLanin
approved these changes
Aug 20, 2026
AlexanderLanin
previously approved these changes
Aug 20, 2026
AlexanderLanin
left a comment
AlexanderLanin
left a comment
Member
There was a problem hiding this comment.
fine for infrastructure work either way; some sort of alignment is always preferred for us
RolandJentschETAS
previously approved these changes
Aug 20, 2026
| Context | ||
| ------- | ||
|
|
||
| The S-CORE project defines as part of the project's processes a `module folder structure <https://eclipse-score.github.io/score/main/contribute/general/folder.html#module-folder-structure>`_. |
Contributor
There was a problem hiding this comment.
Add link and one sentence from central folder definition in S-CORE to this DR ?
aschemmel-tech
dismissed stale reviews from RolandJentschETAS, AlexanderLanin, and LittleHuba
via
August 20, 2026 09:12
c80bc05
aschemmel-tech
dismissed stale reviews from MaciejKaszynski, 4og, and PandaeDo
via
August 20, 2026 09:12
c80bc05
RolandJentschETAS
approved these changes
Aug 20, 2026
Contributor
|
Documentation preview for this pull request is available at: |
RolandJentschETAS
approved these changes
Aug 20, 2026
umaucher
added a commit
to eclipse-score/persistency
that referenced
this pull request
Aug 21, 2026
Removes the top-level /src and /tests folders and the cpp/rust language split, per eclipse-score/score#3194 (module folder structure DR): the src folder is optional and dropped, public interfaces live directly in score/<component>/, and internal/rust_kvs/rust_kvs_tool become lower_level_comp folders. Integration test suites move to score/kvs/tests/ since this module has a single component. Updates all Bazel targets, CI workflows, Cargo/pytest config, and docs that referenced the old paths, including the coverage targets newly introduced by #380.
Contributor
|
fine for persistency ... realization in eclipse-score/persistency#386 |
anmittag
approved these changes
Aug 24, 2026
a-zw
requested changes
Aug 24, 2026
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| DR-002-Proc: Module Folder Structure |
Contributor
There was a problem hiding this comment.
Suggested change
| DR-002-Proc: Module Folder Structure | |
| DR-003-Proc: Module Folder Structure |
umaucher
added a commit
to eclipse-score/persistency
that referenced
this pull request
Aug 24, 2026
Removes the top-level /src and /tests folders and the cpp/rust language split, per eclipse-score/score#3194 (module folder structure DR): the src folder is optional and dropped, public interfaces live directly in score/<component>/, and internal/rust_kvs/rust_kvs_tool become lower_level_comp folders. Integration test suites move to score/kvs/tests/ since this module has a single component. Updates all Bazel targets, CI workflows, Cargo/pytest config, and docs that referenced the old paths, including the coverage targets newly introduced by #380.
umaucher
added a commit
to eclipse-score/persistency
that referenced
this pull request
Aug 24, 2026
…cture (#386) * restructure: align module folder layout with score DR Removes the top-level /src and /tests folders and the cpp/rust language split, per eclipse-score/score#3194 (module folder structure DR): the src folder is optional and dropped, public interfaces live directly in score/<component>/, and internal/rust_kvs/rust_kvs_tool become lower_level_comp folders. Integration test suites move to score/kvs/tests/ since this module has a single component. Updates all Bazel targets, CI workflows, Cargo/pytest config, and docs that referenced the old paths, including the coverage targets newly introduced by #380. * ci: run same-repo PR workflows via pull_request, not stale main pull_request_target always evaluates the workflow YAML from the base branch (main) while checking out the PR's source tree. Since this PR's branch lives in eclipse-score/persistency itself (not a fork), the build/docs/license-check checks kept running main's stale workflow copy against the restructured tree and failed on removed paths. Add a same-repo pull_request trigger alongside pull_request_target, gated so same-repo PRs run untrusted-secret-free via pull_request and fork PRs still require approval via pull_request_target. * docs: align module documentation and generated paths Keep module-level documentation under docs/module as required by the SCORE module folder structure, and keep KVS component documentation and diagrams under score/kvs/docs. Document the intentional single-component layout: component tests remain under score/kvs/tests, while the optional component src directory is omitted so public interfaces and implementation files stay directly in score/kvs. Update the moved documentation toctree, test README paths, and QNX image references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DR raised based on the discussion here:
https://github.com/orgs/eclipse-score/discussions/434#discussioncomment-18048797