Fix/eshost agent module tempdir - #9
Merged
Merged
Conversation
…in place Commit 0637cdc stopped copying module-flagged .js entries to a .mjs twin so self/cyclic imports dedupe, but its unit test still expected the spawned entry to be the .mjs copy, so `bun run test:harness` has failed since. Assert the entry runs under its real name and that no .mjs copy is written, and drop the stale comment describing the old behavior. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUv4hgo7tNxoWuXLDRwXS2
The manifest tests guarded on the suite directory existing, but a checkout without submodules still has the empty placeholder directories, so they ran against nothing and failed. Guard on the directory being populated instead. The registry test still expected the javac jtreg case timeout to be 300s after registry.toml raised it to 900s. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUv4hgo7tNxoWuXLDRwXS2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.