fix: link eboot_stage1 into test_recovery - #35
Merged
srpatcha merged 1 commit intoAug 27, 2026
Conversation
Diksha18Singh
requested review from
hshanmug12,
maheshmunnangi and
srpatcha
as code owners
August 26, 2026 00:27
test_recovery failed to link with undefined symbols for eos_boot_log_append, eos_boot_log_read, and eos_boot_log_get_head. core/recovery.c calls these functions (declared via local extern matching the real implementation), but the implementation lives in stage1/boot_log.c, which is built into the eboot_stage1 library — not eboot_core, which is all test_recovery was linked against. Fix: link eboot_stage1 into test_recovery, matching the dependency recovery.c actually has at runtime. Verified: ctest --test-dir build --output-on-failure now shows 14/14 tests passing (previously 13/14, with test_recovery Not Run due to the link failure).
Diksha18Singh
force-pushed
the
fix/test-recovery-link
branch
from
August 26, 2026 00:28
2fb4975 to
0671013
Compare
This was referenced Aug 26, 2026
10 tasks
srpatcha
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_recovery failed to link with undefined symbols for eos_boot_log_append, eos_boot_log_read, and eos_boot_log_get_head.
core/recovery.c calls these functions (declared via a local extern matching the real implementation), but the implementation lives in stage1/boot_log.c, which is built into the eboot_stage1 library — not eboot_core, which is all test_recovery was linked against.
Fix: link eboot_stage1 into test_recovery, matching the dependency recovery.c actually has at runtime.
Verified: ctest --test-dir build --output-on-failure now shows 14/14 tests passing (previously 13/14, with test_recovery Not Run due to the link failure).
Note: this produces a harmless linker warning ("ignoring duplicate libraries: '../libeboot_core.a'"), since eboot_stage1 already links eboot_core internally. Not addressed here — flagging for visibility rather than silently leaving it unmentioned.
Separately, while investigating this I found that include/eos_boot_log.h declares different signatures for eos_boot_log_init and eos_boot_log_read than what stage1/boot_log.c actually implements, and that test_boot_log.c's test doubles match the header's (incorrect) signature rather than the real implementation. That's a distinct issue from this link fix and I'm opening it separately rather than folding it into this PR.