fix: return test runner exit code - #42
Open
moonluna50 wants to merge 1 commit into
Open
Conversation
moonluna50
requested review from
hshanmug12,
maheshmunnangi and
srpatcha
as code owners
August 26, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
run_all_tests.pytest runner calledsys.exit()before returning the pytest exit code. This made the remaining code unreachable and caused the unit test for the runner's exit-code behavior to fail.Approach
Simplified
run_tests()to:TEST_PATHSconstant.result.returncodeto the caller.SystemExitbehavior through the__main__entry point.This also removes duplicated and unreachable test-runner logic.
Testing
Ran the complete production-ready test suite:
The previously failing
test_runner_uses_current_python_interpretertest now passes.Also ran
git diff --checksuccessfully.Considerations / Limitations
This change only fixes the test runner's exit-code handling. It does not modify the underlying eBoot functionality or production bootloader behavior.